replace pkg/errors with stdlib errors

[neel-astro]

Description

Changes:

• Moved from pkg/errors to stdlib errors package as both are functionally almost the same with later being the only package which would receive new functional updates in future. Changes for this migration were:
  • Replace Wrap method with fmt.Errorf with %w formatting verb
  • As we moved away from pkg/errors, golinter was able to pick up more of err113 linting issues for moving the wrapped static errors from code logic to package level vars

🎟 Issue(s)

Related astronomer/issues#3965

🧪 Functional Testing

List the functional testing steps to confirm this feature or fix.

📸 Screenshots

Add screenshots to illustrate the validity of these changes.

📋 Checklist

• Rebased from the main (or release if patching) branch (before testing)
• Ran make test before taking out of draft
• Added/updated applicable tests
• Tested against Houston-API and Astronomer (if necessary).
• Communicated to/tagged owners of respective clients potentially impacted by these changes.
• Updated any related documentation

[codecov]

Codecov Report

Merging #484 (7db031c) into main (301ea78) will increase coverage by 0.03%.
The diff coverage is 29.41%.

@@            Coverage Diff             @@
##             main     #484      +/-   ##
==========================================
+ Coverage   66.27%   66.30%   +0.03%     
==========================================
  Files          42       42              
  Lines        3644     3642       -2     
==========================================
  Hits         2415     2415              
+ Misses       1056     1054       -2     
  Partials      173      173              

Impacted Files	Coverage Δ
airflow/container.go	48.35% <0.00%> (ø)
airflow/docker_image.go	11.39% <0.00%> (ø)
airflow/docker_registry.go	0.00% <0.00%> (ø)
airflow_versions/http_client.go	79.31% <0.00%> (ø)
cluster/cluster.go	27.14% <0.00%> (ø)
cmd/completion.go	84.00% <0.00%> (ø)
cmd/deploy.go	27.65% <0.00%> (ø)
cmd/deployment.go	85.22% <0.00%> (ø)
cmd/workspace.go	68.95% <0.00%> (ø)
config/config.go	46.37% <0.00%> (ø)
... and 14 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 301ea78...7db031c. Read the comment docs.

[bote795]

do they both return a string? sorry not super familiar with the libs just want to make sure we are not losing any behavior

[neel-astro]

Both of them will return an interface of type error which is simply having one method Error() which would return the string of that error.

The only major functional difference between the two libs are that pkg/errors support error stack trace which isn't present in stdlib errors, but that's something which we anyways don't use it in CLI.

Found a decent blog post illustrating that: https://blog.dharnitski.com/2019/09/09/go-errors-are-not-pkg-errors/

[andriisoldatenko]

well done!