added health check in webserver docker container #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #486 +/- ##
==========================================
+ Coverage 66.30% 66.35% +0.04%
==========================================
Files 42 42
Lines 3642 3662 +20
==========================================
+ Hits 2415 2430 +15
- Misses 1054 1058 +4
- Partials 173 174 +1
Continue to review full report at Codecov.
|
neel-astro
requested review from
aliotta,
andriisoldatenko and
bote795
as code owners
andriisoldatenko
approved these changes
Jan 25, 2022
bote795
reviewed
Jan 25, 2022
airflow/docker.go
Outdated
| func (d *DockerCompose) webserverHealthCheck() error { | ||
| err := d.composeService.Events(context.Background(), d.projectName, api.EventsOptions{ | ||
| Services: []string{config.CFG.WebserverContainerName.GetString()}, Consumer: func(event api.Event) error { | ||
| if event.Status == "health_status: healthy" { |
There was a problem hiding this comment.
can this status be a const string? followed by the exec_die as well?
There was a problem hiding this comment.
make sense, will move it to a package level constant
There was a problem hiding this comment.
moved to a package level constant
AmFlint
reviewed
Jan 28, 2022
neel-astro
force-pushed
the
fix/docker-airflow-settings
branch
2 times, most recently
from
1a2639a
to
d145719
Compare
neel-astro
force-pushed
the
fix/docker-airflow-settings
branch
from
3016fb1
to
50a4876
Compare
AmFlint
approved these changes
Jan 31, 2022
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes:
馃師 Issue(s)
Related astronomer/issues#3370
Related astronomer/issues#2997
馃И Functional Testing
馃摳 Screenshots
馃搵 Checklist
make testbefore taking out of draft