Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added command to fetch triggerer logs #489

Merged
merged 1 commit into from
Feb 7, 2022
Merged

Conversation

neel-astro
Copy link
Contributor

Description

Changes:

  • Added command astro deployment logs triggerer to fetch Airflow triggerer logs, command will only be visible if the feature flag is set.
  • Consolidate webserverRemoteLogs, schedulerRemoteLogs & workerRemoteLogs into a single fetchRemoteLogs method.

🎟 Issue(s)

Related astronomer/issues#3807

🧪 Functional Testing

List the functional testing steps to confirm this feature or fix.

📸 Screenshots

Add screenshots to illustrate the validity of these changes.

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Added/updated applicable tests
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

@codecov
Copy link

codecov bot commented Jan 28, 2022

Codecov Report

Merging #489 (273dd27) into main (d25d541) will increase coverage by 0.11%.
The diff coverage is 65.11%.

❗ Current head 273dd27 differs from pull request most recent head 9b67585. Consider uploading reports for the commit 9b67585 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #489      +/-   ##
==========================================
+ Coverage   66.31%   66.43%   +0.11%     
==========================================
  Files          42       42              
  Lines        3684     3667      -17     
==========================================
- Hits         2443     2436       -7     
+ Misses       1062     1054       -8     
+ Partials      179      177       -2     
Impacted Files Coverage Δ
cmd/logs.go 85.32% <63.41%> (-0.40%) ⬇️
cmd/deployment.go 85.22% <100.00%> (+1.58%) ⬆️
cmd/root.go 89.18% <100.00%> (ø)
airflow/docker.go 48.93% <0.00%> (-2.51%) ⬇️
cmd/deploy.go 27.65% <0.00%> (-0.92%) ⬇️
deployment/deployment.go 85.51% <0.00%> (-0.63%) ⬇️
houston/types.go 55.00% <0.00%> (ø)
airflow/podman.go 77.11% <0.00%> (ø)
airflow/airflow.go 70.37% <0.00%> (ø)
airflow/docker_image.go 11.39% <0.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d25d541...9b67585. Read the comment docs.

@neel-astro neel-astro marked this pull request as ready for review January 28, 2022 12:34
cmd/logs.go Outdated Show resolved Hide resolved
cmd/logs.go Outdated Show resolved Hide resolved
cmd/logs.go Outdated Show resolved Hide resolved
cmd/logs_test.go Show resolved Hide resolved
cmd/deployment.go Show resolved Hide resolved
Copy link
Contributor

@bote795 bote795 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AmFlint
Copy link
Contributor

AmFlint commented Feb 7, 2022

Can we merge this PR please?

@neel-astro neel-astro merged commit b5810c8 into main Feb 7, 2022
@neel-astro neel-astro deleted the fix/triggerer-logs branch September 26, 2022 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants