Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To enable (NamespaceFreeformEntry) pre-deployment webhook, no longer need to check/enable ManualNamespaceNames #493

Merged
merged 1 commit into from
Feb 1, 2022

Conversation

ajayy004
Copy link
Contributor

@ajayy004 ajayy004 commented Feb 1, 2022

Description

To enable (NamespaceFreeformEntry) pre-deployment webhook, no longer need to check/enable ManualNamespaceNames

🎟 Issue(s)

Related astronomer/issues#4132

🧪 Functional Testing

List the functional testing steps to confirm this feature or fix.

📸 Screenshots

Add screenshots to illustrate the validity of these changes.

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Added/updated applicable tests
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

@ajayy004 ajayy004 marked this pull request as ready for review February 1, 2022 16:49
@codecov
Copy link

codecov bot commented Feb 1, 2022

Codecov Report

Merging #493 (c9cdd4e) into main (307bc61) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #493   +/-   ##
=======================================
  Coverage   66.45%   66.45%           
=======================================
  Files          42       42           
  Lines        3658     3658           
=======================================
  Hits         2431     2431           
  Misses       1054     1054           
  Partials      173      173           
Impacted Files Coverage Δ
deployment/deployment.go 86.14% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 307bc61...c9cdd4e. Read the comment docs.

Copy link
Contributor

@neel-astro neel-astro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine 👍

@ajayy004 ajayy004 merged commit 7fedcde into main Feb 1, 2022
@ajayy004 ajayy004 deleted the feature/4132 branch February 1, 2022 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants