Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missed out new line char in deployment link log #498

Merged
merged 2 commits into from
Feb 9, 2022

Conversation

neel-astro
Copy link
Contributor

@neel-astro neel-astro commented Feb 9, 2022

Description

Changes:

  • Added the missed out new line character in the new deployment link which is part astro deploy output
  • Kept the health check in docker webserver same as that of podman webserver

馃師 Issue(s)

Related astronomer/issues#4219

馃И Functional Testing

List the functional testing steps to confirm this feature or fix.

馃摳 Screenshots

Add screenshots to illustrate the validity of these changes.

馃搵 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Added/updated applicable tests
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

@codecov
Copy link

codecov bot commented Feb 9, 2022

Codecov Report

Merging #498 (a4d3fdf) into main (cdb731a) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #498   +/-   ##
=======================================
  Coverage   66.28%   66.28%           
=======================================
  Files          42       42           
  Lines        3710     3710           
=======================================
  Hits         2459     2459           
  Misses       1064     1064           
  Partials      187      187           
Impacted Files Coverage 螖
cmd/deploy.go 28.57% <0.00%> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update cdb731a...a4d3fdf. Read the comment docs.

@neel-astro neel-astro merged commit cdc01c9 into main Feb 9, 2022
neel-astro added a commit that referenced this pull request Feb 9, 2022
* added missed out new line char

* Merge branch 'main' into fix/deployment-link
@neel-astro neel-astro deleted the fix/deployment-link branch September 26, 2022 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants