Astro Run Command #776
Astro Run Command #776
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…into astro-test
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Codecov ReportBase: 87.19% // Head: 87.20% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #776 +/- ##
==========================================
+ Coverage 87.19% 87.20% +0.01%
==========================================
Files 107 108 +1
Lines 9107 9294 +187
==========================================
+ Hits 7941 8105 +164
- Misses 688 700 +12
- Partials 478 489 +11
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
airflow/docker_image.go
Outdated
| @@ -276,6 +276,91 @@ func (d *DockerImage) TagLocalImage(localImage string) error { | |||
| return nil | |||
| } | |||
|
|
|||
| func (d *DockerImage) Run(dagID, envFile, settingsFile, containerName string, taskLogs bool) error { | |||
| // delete container | |||
There was a problem hiding this comment.
| // delete container |
nit: is it still relevant, or else we can drop it?
There was a problem hiding this comment.
yes we need to delete the container here just in case on exists and wasn't deleted before for some reason
There was a problem hiding this comment.
yeah, but the comment over here does not fit any purpose to have it at the start of Run function, makes sense to have it where we are deleting the container but that is already there
Co-authored-by: Neel Dalsania <neel.dalsania@astronomer.io>
…into astro-test
airflow/docker_image.go
Outdated
| @@ -276,6 +276,91 @@ func (d *DockerImage) TagLocalImage(localImage string) error { | |||
| return nil | |||
| } | |||
|
|
|||
| func (d *DockerImage) Run(dagID, envFile, settingsFile, containerName string, taskLogs bool) error { | |||
| // delete container | |||
There was a problem hiding this comment.
yeah, but the comment over here does not fit any purpose to have it at the start of Run function, makes sense to have it where we are deleting the container but that is already there
|
@neel-astro I moved the comment |
for more information, see https://pre-commit.ci
…into astro-test
for more information, see https://pre-commit.ci
Description
new astro run command
inlcudes dags and changes to the docker file that are for testing purposes only. These changes will be removed once the command is merged
🎟 Issue(s)
🧪 Functional Testing
Added tests for new functions
📸 Screenshots
📋 Checklist
make testbefore taking out of draftmake lintbefore taking out of draft