Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to go 1.19.3 #856

Merged
merged 3 commits into from
Nov 12, 2022
Merged

Upgrade to go 1.19.3 #856

merged 3 commits into from
Nov 12, 2022

Conversation

neel-astro
Copy link
Contributor

@neel-astro neel-astro commented Nov 3, 2022

Description

Changes:

  • Upgrade to go 1.19.3
  • Upgrade golangci-lint to 1.50.1
  • Get rid of deprecated linter packages
  • Fix linter errors in the codebase

🎟 Issue(s)

Related #765, #831

🧪 Functional Testing

List the functional testing steps to confirm this feature or fix.

📸 Screenshots

Add screenshots to illustrate the validity of these changes.

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Base: 87.09% // Head: 87.09% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (b505252) compared to base (8bf791a).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #856   +/-   ##
=======================================
  Coverage   87.09%   87.09%           
=======================================
  Files         103      103           
  Lines        8948     8949    +1     
=======================================
+ Hits         7793     7794    +1     
  Misses        676      676           
  Partials      479      479           
Impacted Files Coverage Δ
airflow/container.go 63.79% <ø> (ø)
airflow/docker.go 86.70% <ø> (ø)
cmd/cloud/deployment.go 91.74% <ø> (ø)
pkg/printutil/printutil.go 83.09% <ø> (ø)
software/auth/auth.go 81.87% <ø> (ø)
astro-client/client.go 75.00% <100.00%> (ø)
cloud/auth/auth.go 80.88% <100.00%> (ø)
cloud/deploy/deploy.go 73.13% <100.00%> (ø)
cloud/deployment/deployment.go 89.25% <100.00%> (ø)
cloud/deployment/deployment_variable.go 89.11% <100.00%> (ø)
... and 18 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kushalmalani
Copy link
Contributor

@neel-astro Can we wait to merge this until 1.7.0 is out?

Copy link
Contributor

@andriisoldatenko andriisoldatenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@neel-astro neel-astro merged commit 066e35d into main Nov 12, 2022
@neel-astro neel-astro deleted the upgrade-go-1.19.3 branch November 12, 2022 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants