log into pr preview environments #865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 87.11% // Head: 87.14% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #865 +/- ##
==========================================
+ Coverage 87.11% 87.14% +0.02%
==========================================
Files 106 107 +1
Lines 9083 9068 -15
==========================================
- Hits 7913 7902 -11
+ Misses 689 688 -1
+ Partials 481 478 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
jemishp
added
team/platform-airflowprov
app/astro-cli
and removed
team/platform-airflowprov
labels
jemishp
force-pushed
the
805-allow-pr-preview-logins
branch
from
02e97ff
to
5cf2232
Compare
jemishp
requested review from
andriisoldatenko,
aliotta,
neel-astro,
AmFlint,
kushalmalani and
sunkickr
as code owners
jemishp
force-pushed
the
805-allow-pr-preview-logins
branch
from
5cf2232
to
3f89961
Compare
jcom000
reviewed
Nov 9, 2022
pkg/domainutil/domain.go
Outdated
| // See https://github.com/astronomer/astrohub-cli/issues/7 for regexp rationale | ||
| // This will need to be handled as part of the permanent solution to issue #432 | ||
| CloudDomainRegex = regexp.MustCompile(`(cloud\.|^)astronomer(?:(-dev|-stage|-perf))?\.io`) | ||
| PRPreviewDomainRegex = regexp.MustCompile(`(pr\d{4}\.)astronomer(-dev)\.io$`) |
There was a problem hiding this comment.
^(pr\d{4+}\).astronomer-dev\.io$
matches := re.FindStringSubmatch would get you one result here
There was a problem hiding this comment.
I changed it to ^(pr\d{4,6}).astronomer-dev\.io$ so that it still has an upper limit on the numbers.
jcom000
reviewed
Nov 10, 2022
jcom000
reviewed
Nov 10, 2022
jcom000
reviewed
Nov 10, 2022
jemishp
force-pushed
the
805-allow-pr-preview-logins
branch
5 times, most recently
from
9a883db
to
3ed56f9
Compare
neel-astro
approved these changes
Nov 11, 2022
| } | ||
|
|
||
| func getPRSubDomain(domain string) (prSubDomain, restOfDomain string) { | ||
| if isPrPreviewDomain(domain) { |
There was a problem hiding this comment.
nit: this is a duplicate check, since the caller already checks if it's a pr preview domain and then only calls this method
jemishp
force-pushed
the
805-allow-pr-preview-logins
branch
from
3ed56f9
to
d44b351
Compare
- `auth.Login()` succeeds with a valid pr preview env - `auth.formatDomain()` and `auth.ValidateDomain()` allow pr preview - `config.IsCloudContext()` allows pr preview - add a pr prveiew context to `testing.NewTestConfig()` - TODO - address a few TODOs
- anytime we need to check domain or URLs to be derived from a domain for the user login flow, we use the `domainutil` package - tighten up the domain and pr preview regexes - able to transform astrohub url -> core api url for valid domains - remove redundant `GetCloudAPIURL()`
jemishp
force-pushed
the
805-allow-pr-preview-logins
branch
from
d44b351
to
f165b4c
Compare
kushalmalani
approved these changes
Nov 16, 2022
There was a problem hiding this comment.
LGTM...i tested this against local and dev environment to make sure we are not causing a regression
Great work on this @jemishp 🎉
sunkickr
approved these changes
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Users can now log into pr preview environments using astro cli
🎟 Issue(s)
Related #805 Related #808
🧪 Functional Testing
📋 Checklist
make testbefore taking out of draftmake lintbefore taking out of draft