-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flow command flags #877
Conversation
Codecov ReportBase: 87.14% // Head: 87.14% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #877 +/- ##
=======================================
Coverage 87.14% 87.14%
=======================================
Files 106 106
Lines 9105 9105
=======================================
Hits 7935 7935
Misses 689 689
Partials 481 481
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to update any tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should plan to add some e2e tests for flow commands once we get some time, that will give us more confidence in our changes
Reference: https://github.com/astronomer/automated-cli-tests
Yes, with e2e tests we would have detected that. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for identifying and fixing this quickly @feluelle :) I missed that while reviewing.
Description
The related PR (see below) broke the flags creation. This PR fixes it.
🎟 Issue(s)
Related #860
📋 Checklist
make test
before taking out of draftmake lint
before taking out of draft