Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flow command flags #877

Merged
merged 1 commit into from
Nov 16, 2022
Merged

Fix flow command flags #877

merged 1 commit into from
Nov 16, 2022

Conversation

feluelle
Copy link
Member

Description

The related PR (see below) broke the flags creation. This PR fixes it.

🎟 Issue(s)

Related #860

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

@codecov
Copy link

codecov bot commented Nov 16, 2022

Codecov Report

Base: 87.14% // Head: 87.14% // No change to project coverage 👍

Coverage data is based on head (445c931) compared to base (9d2377f).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #877   +/-   ##
=======================================
  Coverage   87.14%   87.14%           
=======================================
  Files         106      106           
  Lines        9105     9105           
=======================================
  Hits         7935     7935           
  Misses        689      689           
  Partials      481      481           
Impacted Files Coverage Δ
sql/flow.go 91.95% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@tatiana tatiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to update any tests?

Copy link
Contributor

@neel-astro neel-astro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should plan to add some e2e tests for flow commands once we get some time, that will give us more confidence in our changes
Reference: https://github.com/astronomer/automated-cli-tests

@feluelle
Copy link
Member Author

Yes, with e2e tests we would have detected that. 👍

@neel-astro neel-astro merged commit e4d112e into main Nov 16, 2022
@neel-astro neel-astro deleted the fix/flow-command-flags branch November 16, 2022 14:21
Copy link
Contributor

@pankajkoti pankajkoti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for identifying and fixing this quickly @feluelle :) I missed that while reviewing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants