minor changes to astro deployment inspect #884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `information` is now `metadata` - `scheduler_replicas` is now `scheduler_count` - `astronomer_variables` is now `environment_variables` - re-order fields in the `deploymentMetadata` and `deploymentConfiguration` structs
- use `mapstructre.Decode()` to convert to struct once to get ordered output
- rename `getDeploymentInspectInfo()` o `getDeploymentInfo()`
jemishp
requested review from
andriisoldatenko,
aliotta,
neel-astro,
AmFlint and
kushalmalani
as code owners
Codecov ReportBase: 87.19% // Head: 87.20% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #884 +/- ##
=======================================
Coverage 87.19% 87.20%
=======================================
Files 107 107
Lines 9107 9112 +5
=======================================
+ Hits 7941 7946 +5
Misses 688 688
Partials 478 478
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
neel-astro
approved these changes
Nov 18, 2022
kushalmalani
approved these changes
Nov 18, 2022
sunkickr
approved these changes
Nov 18, 2022
andriisoldatenko
approved these changes
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr adds ordered output when printing deployments. Also renamed a few keys based on user feedback.
🎟 Issue(s)
Related #876
🧪 Functional Testing
yaml output
$ astro deployment inspect claaesqk6329512z1h8f62bn12 deployment: environment_variables: - is_secret: true key: FOO updated_at: "2022-11-10T01:48:09.961Z" value: "" configuration: name: andytest description: "" runtime_version: 6.0.3 scheduler_au: 5 scheduler_count: 1 cluster_id: cl6zcnlc600ht0vuibivf53jh worker_queues: - name: default id: claaesqk7329542z1h9u8isby3 is_default: true max_worker_count: 10 min_worker_count: 0 worker_concurrency: 16 node_pool_id: cl6zcnlc8395442eui99mvlqhv metadata: deployment_id: claaesqk6329512z1h8f62bn12 workspace_id: cl6wg2zra144002dyw8px6t6ip cluster_id: cl6zcnlc600ht0vuibivf53jh release_name: combusting-velocity-9074 airflow_version: 2.4.2 dag_deploy_enabled: false status: HEALTHY created_at: 2022-11-10T01:46:26.55Z updated_at: 2022-11-11T18:05:22.567Z deployment_url: cloud.astronomer-dev.io/cl6wg2zra144002dyw8px6t6ip/deployments/claaesqk6329512z1h8f62bn12/analytics webserver_url: astronomer.astronomer-dev.run/df62bn12?orgId=org_dlgevirUCwI9vX10 alert_emails: []json output
$ astro deployment inspect claaesqk6329512z1h8f62bn12 -o json { "deployment": { "environment_variables": [ { "is_secret": true, "key": "FOO", "updated_at": "2022-11-10T01:48:09.961Z", "value": "" } ], "configuration": { "name": "andytest", "description": "", "runtime_version": "6.0.3", "scheduler_au": 5, "scheduler_count": 1, "cluster_id": "cl6zcnlc600ht0vuibivf53jh" }, "worker_queues": [ { "name": "default", "id": "claaesqk7329542z1h9u8isby3", "is_default": true, "max_worker_count": 10, "min_worker_count": 0, "worker_concurrency": 16, "node_pool_id": "cl6zcnlc8395442eui99mvlqhv" } ], "metadata": { "deployment_id": "claaesqk6329512z1h8f62bn12", "workspace_id": "cl6wg2zra144002dyw8px6t6ip", "cluster_id": "cl6zcnlc600ht0vuibivf53jh", "release_name": "combusting-velocity-9074", "airflow_version": "2.4.2", "dag_deploy_enabled": false, "status": "HEALTHY", "created_at": "2022-11-10T01:46:26.55Z", "updated_at": "2022-11-11T18:05:22.567Z", "deployment_url": "cloud.astronomer-dev.io/cl6wg2zra144002dyw8px6t6ip/deployments/claaesqk6329512z1h8f62bn12/analytics", "webserver_url": "astronomer.astronomer-dev.run/df62bn12?orgId=org_dlgevirUCwI9vX10" }, "alert_emails": [] } }📸 Screenshots
📋 Checklist
make testbefore taking out of draftmake lintbefore taking out of draft