Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip tests when no dags available #886

Merged
merged 4 commits into from
Nov 18, 2022
Merged

skip tests when no dags available #886

merged 4 commits into from
Nov 18, 2022

Conversation

kushalmalani
Copy link
Contributor

@kushalmalani kushalmalani commented Nov 18, 2022

Description

Describe the purpose of this pull request.

Skip tests when no dags available

🎟 Issue(s)

Related #869

🧪 Functional Testing

List the functional testing steps to confirm this feature or fix.

📸 Screenshots

Add screenshots to illustrate the validity of these changes.

Screen Shot 2022-11-18 at 10 30 15

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

@codecov
Copy link

codecov bot commented Nov 18, 2022

Codecov Report

Base: 87.20% // Head: 87.20% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (7ca697a) compared to base (cbc88e4).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #886   +/-   ##
=======================================
  Coverage   87.20%   87.20%           
=======================================
  Files         107      107           
  Lines        9112     9115    +3     
=======================================
+ Hits         7946     7949    +3     
  Misses        688      688           
  Partials      478      478           
Impacted Files Coverage Δ
cloud/deploy/deploy.go 73.74% <100.00%> (+0.21%) ⬆️
cloud/deployment/deployment.go 89.51% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@neel-astro neel-astro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, left a nitpick in unit tests

cloud/deploy/deploy_test.go Show resolved Hide resolved
Copy link
Contributor

@jemishp jemishp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kushalmalani kushalmalani merged commit 7713e89 into main Nov 18, 2022
@kushalmalani kushalmalani deleted the skip-tests-no-dags branch November 18, 2022 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants