Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for incorrect cloud domain identification #890

Merged
merged 1 commit into from
Nov 19, 2022

Conversation

jemishp
Copy link
Contributor

@jemishp jemishp commented Nov 19, 2022

Description

This pr fixes a a login issue where a valid cloud domain login was getting rejected. This was because it was incorrectly identified as a software domain.

🎟 Issue(s)

Related #889

🧪 Functional Testing

$ astro login https://cloud.astronomer-dev.io/

Welcome to the Astro CLI 🚀

To learn more about Astro, go to https://docs.astronomer.io

Please enter your account email: jemish.patel@astronomer.io

Press Enter to open the browser to log in or ^C to quit…
done
 CONTEXT DOMAIN                      WORKSPACE
 astronomer-dev.io                   cl6wg2zra144002dyw8px6t6ip

 Switched context

"Production Readiness E2E" Workspace found. This is your default Workspace.

Successfully authenticated to Astronomer

📸 Screenshots

Add screenshots to illustrate the validity of these changes.

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

- if user logs in `https://cloud.astronomer-dev.io` it gets validated as cloud domaini
- before it used to incorrectly get identified as software domain
@codecov
Copy link

codecov bot commented Nov 19, 2022

Codecov Report

Base: 87.20% // Head: 87.21% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (a4f7b02) compared to base (7713e89).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #890   +/-   ##
=======================================
  Coverage   87.20%   87.21%           
=======================================
  Files         107      107           
  Lines        9115     9117    +2     
=======================================
+ Hits         7949     7951    +2     
  Misses        688      688           
  Partials      478      478           
Impacted Files Coverage Δ
context/context.go 82.05% <ø> (ø)
pkg/domainutil/domain.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kushalmalani kushalmalani merged commit 087e021 into main Nov 19, 2022
@kushalmalani kushalmalani deleted the 889-cloud-domain-https branch November 19, 2022 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cloud domain could have https in it
2 participants