Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable astronomer update-check in flow env #895

Merged
merged 1 commit into from
Nov 23, 2022

Conversation

feluelle
Copy link
Member

Description

Currently, when running flow in the astro-runtime image we continuously check for updates. This is not necessary for the flow environment.

Furthermore, the flow command will only be used locally hence when we deploy to astro (cloud) we will use a different image for running this workflow anyway.

🎟 Issue(s)

Related astronomer/astro-sdk#1286

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

@codecov
Copy link

codecov bot commented Nov 23, 2022

Codecov Report

Base: 87.28% // Head: 87.28% // No change to project coverage 👍

Coverage data is based on head (405282a) compared to base (e6b73ff).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #895   +/-   ##
=======================================
  Coverage   87.28%   87.28%           
=======================================
  Files         108      108           
  Lines        9317     9317           
=======================================
  Hits         8132     8132           
  Misses        697      697           
  Partials      488      488           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@neel-astro neel-astro merged commit cdd6bf4 into main Nov 23, 2022
@neel-astro neel-astro deleted the fix/disable-update-check-flow-environment branch November 23, 2022 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants