Support for existing_cluster_id in DatabricksNotebookOperator #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pankajkoti
reviewed
Apr 2, 2024
pankajkoti
reviewed
Apr 2, 2024
There was a problem hiding this comment.
LGTM in general. Have a question inline.
@dimberman would you please be able to offer additional pair of eyes and help review the PR if possible?
pankajkoti
approved these changes
Apr 2, 2024
phanikumv
approved these changes
Apr 3, 2024
|
@Hang1225 I modified the PR description and commit message to elaborate further. Next, I will work soon on releasing this fix. Thanks a lot for reporting the issue and contributing a fix, appreciate it 👏🏽 |
|
Hi @Hang1225 we just released 0.2.1 of the provider https://pypi.org/project/astro-provider-databricks/0.2.1/ which should include this PR. Please try out the new released version and also please let us know if it helps your use case. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When tasks are launched with
DatabricksNotebookOperatorsfrom within a TaskGroupusing the
DatabricksWorkflowTaskGroup, currently we do not support usingexisting_cluster_idfor those Notebook tasks. The PR addresses this issue by allowing to support
existing_cluster_idin such cases and additionally also keeps supporting the currentjob_cluster_keyapproach allowing users to use a combination of both for a workflow.closes: #70