Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change tmp_dir in base operator to be in line with Airflow 2.8 #14

Merged
merged 3 commits into from
Jan 1, 2024

Conversation

TJaniF
Copy link
Collaborator

@TJaniF TJaniF commented Dec 22, 2023

There was a bugfix in Airflow 2.8 that changed what parameters _execute_python_callable_in_subprocess gets: apache/airflow#35258

This broke the baseoperator for 2.8+

Also there the jinja template for the virtualenv was not included in the whl build process.

MANIFEST.in Outdated Show resolved Hide resolved
Co-authored-by: Pankaj Singh <98807258+pankajastro@users.noreply.github.com>
Copy link
Contributor

@pankajastro pankajastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, But for public release I feel we should wait for #13

@TJaniF TJaniF merged commit a416aa5 into astronomer:main Jan 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants