Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add user facing doc for Snowflake behaviour for cols #1098

Closed
utkarsharma2 opened this issue Oct 19, 2022 · 0 comments
Closed

Add user facing doc for Snowflake behaviour for cols #1098

utkarsharma2 opened this issue Oct 19, 2022 · 0 comments
Assignees
@utkarsharma2
Labels
documentation Improvements or additions to documentation product/python-sdk Label describing products
Milestone
1.2.0

Comments

@utkarsharma2
Copy link
Collaborator

Please describe the feature you'd like to see
We don't have any doc exapling the behavior of snowflake and snowflake sqlalchemy with respect to identifiers.

Describe the solution you'd like
We should add a doc explanation for this behavior.
@utkarsharma2 utkarsharma2 added the feature New feature or request label Oct 19, 2022
@kaxil kaxil added this to the 1.2.0 milestone Oct 19, 2022
@pankajastro pankajastro added documentation Improvements or additions to documentation product/python-sdk Label describing products and removed feature New feature or request labels Oct 20, 2022
@pankajastro pankajastro mentioned this issue Oct 20, 2022
Merged
2 tasks
utkarsharma2 added a commit that referenced this issue Oct 20, 2022
@utkarsharma2 @kaxil
Snowflake - Add quotes on col names to preserve the casing (#1050)
14fb31f 
# Description
## What is the current behavior?
Currently, we were changing the case of col names to lowercase for
snowflakes. Which trips user.


closes: #917 #1098 


## What is the new behavior?
We can keep the col names intact by passing them in quotes when creating
tables added quotes.
We no longer need the ColCapitalization feature. 

## Does this introduce a breaking change?
Yes, for pandas path, we will also load "data twice" - one during schema
detection (where we load and truncate) and second during actual load

### Checklist
- [ ] Created tests which fail without the change (if possible)
- [ ] Extended the README / documentation, if necessary

Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@utkarsharma2 utkarsharma2

Labels
documentation Improvements or additions to documentation product/python-sdk Label describing products
Projects
None yet
Milestone
1.2.0
Development

No branches or pull requests
3 participants
@kaxil @utkarsharma2 @pankajastro