Openlineage support - Add Extractor for DataframeOperator
#1183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phanikumv
requested review from
dimberman,
tatiana,
utkarsharma2,
sunank200,
pankajastro,
pankajkoti and
feluelle
as code owners
phanikumv
force-pushed
the
ol_dataframeop
branch
from
f2e252a
to
a0bc58c
Compare
Codecov ReportBase: 94.20% // Head: 94.43% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1183 +/- ##
==========================================
+ Coverage 94.20% 94.43% +0.22%
==========================================
Files 68 16 -52
Lines 3140 521 -2619
Branches 358 51 -307
==========================================
- Hits 2958 492 -2466
+ Misses 120 20 -100
+ Partials 62 9 -53 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
phanikumv
force-pushed
the
ol_dataframeop
branch
2 times, most recently
from
99626df
to
023456e
Compare
|
Marquez UI screenshot:-
|
phanikumv
force-pushed
the
ol_dataframeop
branch
from
1996de2
to
2117acc
Compare
|
LGTM. |
phanikumv
force-pushed
the
ol_dataframeop
branch
from
2117acc
to
35bc7c4
Compare
rajaths010494
approved these changes
Nov 3, 2022
pankajastro
reviewed
Nov 3, 2022
phanikumv
force-pushed
the
ol_dataframeop
branch
4 times, most recently
from
30e45ce
to
3626491
Compare
phanikumv
force-pushed
the
ol_dataframeop
branch
from
3626491
to
9461fb9
Compare
utkarsharma2
approved these changes
Nov 4, 2022
pankajastro
approved these changes
Nov 4, 2022
utkarsharma2
pushed a commit
that referenced
this pull request
Nov 4, 2022
# Description ## What is the current behavior? We are unable to extract open lineage info from the DataframeOperator. closes: #904 ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Added a method get_openlineage_facets on the Operator (based on [this doc](https://docs.google.com/document/d/1vPsvHejQ24xTbzpz_LYSf0_ixk9oUuBiEUHVEaF9J2U/edit?usp=sharing)) - The "PythonSDKExtractor" built-in #898 should be able to work with DataframeOperator.get_openlineage_facets. Tested it to make sure it works ## Does this introduce a breaking change? No ### Checklist - [x] Post the screenshot of how it looks in the Openlineage/Marquez UI - [x] All checks and tests in the CI should pass - [x] Unit tests (90% code coverage or more, #191) - [ ] Integration tests (if the feature relates to a new database or external service) - [ ] Docstrings in [reStructuredText](https://peps.python.org/pep-0287/) for each of methods, classes, functions and module-level attributes (including Example DAG on how it should be used) - [ ] Exception handling in case of errors - [ ] Logging (are we exposing useful information to the user? e.g. source and destination) - [ ] Improve the documentation (README, Sphinx, and any other relevant) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Pankaj Singh <98807258+pankajastro@users.noreply.github.com> Co-authored-by: Pankaj <pankaj.singh@astronomer.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is the current behavior?
We are unable to extract open lineage info from the DataframeOperator.
closes: #904
What is the new behavior?
LoadFileOperator#898 should be able to work with DataframeOperator.get_openlineage_facets. Tested it to make sure it worksDoes this introduce a breaking change?
No
Checklist