Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename the name and namespace for sqlite as per new convention introduced #1281

Closed
sunank200 opened this issue Nov 22, 2022 · 0 comments · Fixed by #1306
Closed

Rename the name and namespace for sqlite as per new convention introduced #1281

sunank200 opened this issue Nov 22, 2022 · 0 comments · Fixed by #1306
Assignees
@rajaths010494
Labels
priority/medium Medium priority
Milestone
1.3.0

Comments

@sunank200
Copy link
Contributor

Describe the bug
There have been new conventions introduced: Naming.md#local-file-system
I believe sqlite counts as local file, therefore you could adjust naming convention in astro as well.

A word of explanation: both IP and port are mandatory. It means that if port is unknown (e. g. if file exists in Airflow's local file system only) you should default to some value. In one of OL extractors it is defaulted to paramiko.config.SSH_PORT, in most cases it's equal to 22.

Reference: #1142 (comment)
@sunank200 sunank200 added the priority/medium Medium priority label Nov 22, 2022
@sunank200 sunank200 added this to the 1.3.0 milestone Nov 22, 2022
@sunank200 sunank200 mentioned this issue Nov 22, 2022
Merged
2 tasks
@rajaths010494 rajaths010494 mentioned this issue Nov 24, 2022
Merged
sunank200 added a commit that referenced this issue Nov 29, 2022
@rajaths010494 @sunank200
OpenLineage: Rename the name and namespace along with URI (#1306)
b725430 
Describe the bug
- There have been new conventions introduced:
[Naming.md#local-file-system](https://github.com/OpenLineage/OpenLineage/blob/main/spec/Naming.md#local-file-system)
I believe sqlite counts as local file, therefore you could adjust naming
convention in astro as well.

A word of explanation: both IP and port are mandatory. It means that if
port is unknown (e. g. if file exists in Airflow's local file system
only) you should default to some value. In one of OL extractors it is
defaulted to paramiko.config.SSH_PORT, in most cases it's equal to 22.

Reference:
#1142 (comment)
- Add openlineage_dataset_uri() method to create URI as per each
database.

closes #1281

Co-authored-by: Ankit Chaurasia <8670962+sunank200@users.noreply.github.com>
sunank200 pushed a commit that referenced this issue Dec 1, 2022
@rajaths010494 @sunank200
OpenLineage: Rename the name and namespace along with URI (#1306)
8b064c0 
Describe the bug
- There have been new conventions introduced:
[Naming.md#local-file-system](https://github.com/OpenLineage/OpenLineage/blob/main/spec/Naming.md#local-file-system)
I believe sqlite counts as local file, therefore you could adjust naming
convention in astro as well.

A word of explanation: both IP and port are mandatory. It means that if
port is unknown (e. g. if file exists in Airflow's local file system
only) you should default to some value. In one of OL extractors it is
defaulted to paramiko.config.SSH_PORT, in most cases it's equal to 22.

Reference:
#1142 (comment)
- Add openlineage_dataset_uri() method to create URI as per each
database.

closes #1281

Co-authored-by: Ankit Chaurasia <8670962+sunank200@users.noreply.github.com>
(cherry picked from commit b725430)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rajaths010494 rajaths010494

Labels
priority/medium Medium priority
Projects
None yet
Milestone
1.3.0
Development

Successfully merging a pull request may close this issue.

OpenLineage: Rename the name and namespace along with URI astronomer/astro-sdk
2 participants
@sunank200 @rajaths010494