Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate export_file before renaming to export_table_to_file #1411

Closed
pankajastro opened this issue Dec 12, 2022 · 0 comments · Fixed by #1412
Closed

Deprecate export_file before renaming to export_table_to_file #1411

pankajastro opened this issue Dec 12, 2022 · 0 comments · Fixed by #1412
Assignees
@pankajastro
Labels
improvement Enhancement or improvement in an existing feature product/python-sdk Label describing products
Milestone
1.4.0

Comments

@pankajastro
Copy link
Contributor

Describe the bug
A clear and concise description of what the bug is.

Version

  • Astro: [e.g. 0.6.0]
  • OS: [eg. Debian]

To Reproduce
Steps to reproduce the behavior:

  1. Write the DAG '...'
  2. Create connection '....'
  3. Run using '....'
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.
@pankajastro pankajastro added the improvement Enhancement or improvement in an existing feature label Dec 12, 2022
This was referenced Dec 12, 2022
Merged
Open
@pankajastro pankajastro self-assigned this Dec 12, 2022
@pankajastro pankajastro added the product/python-sdk Label describing products label Dec 12, 2022
@pankajastro pankajastro added this to the 1.3.1 milestone Dec 13, 2022
pankajastro added a commit that referenced this issue Dec 13, 2022
@pankajastro @pre-commit-ci
Deprecate export_file before renaming it export_table_to_file (#1412
bf60868 
)

# Description
closes: #1411

## What is the current behavior?
we have the `export_file` operator but we want to rename it to
`export_table_to_file` operator since this is the last patch release
before 1.4 so lets deprecate it in 1.3.1


## What is the new behavior?
Deprecate export_file before renaming it export_table_to_file



### Checklist
- [ ] Created tests which fail without the change (if possible)
- [ ] Extended the README / documentation, if necessary

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
utkarsharma2 pushed a commit that referenced this issue Dec 13, 2022
@pankajastro @pre-commit-ci @utkarsharma2
Deprecate export_file before renaming it export_table_to_file (#1412
5c00014 
)

closes: #1411

we have the `export_file` operator but we want to rename it to
`export_table_to_file` operator since this is the last patch release
before 1.4 so lets deprecate it in 1.3.1

Deprecate export_file before renaming it export_table_to_file

- [ ] Created tests which fail without the change (if possible)
- [ ] Extended the README / documentation, if necessary

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@pankajastro pankajastro mentioned this issue Dec 13, 2022
Merged
2 tasks
pankajastro added a commit that referenced this issue Dec 13, 2022
@pankajastro
Fix export_file deprecation message (#1424)
987d0c4 
# Description
Related to: #1411

Address
#1412 (comment)

## Does this introduce a breaking change?
No

### Checklist
- [ ] Created tests which fail without the change (if possible)
- [ ] Extended the README / documentation, if necessary
@utkarsharma2 utkarsharma2 modified the milestones: 1.3.1, 1.4.0 Dec 14, 2022
utkarsharma2 pushed a commit that referenced this issue Dec 15, 2022
@pankajastro @utkarsharma2
Fix export_file deprecation message (#1424)
d3e1d0c 
Related to: #1411

Address
#1412 (comment)

No

- [ ] Created tests which fail without the change (if possible)
- [ ] Extended the README / documentation, if necessary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pankajastro pankajastro

Labels
improvement Enhancement or improvement in an existing feature product/python-sdk Label describing products
Projects
None yet
Milestone
1.4.0
Development

Successfully merging a pull request may close this issue.

Deprecate export_file before renaming it export_table_to_file astronomer/astro-sdk
2 participants
@utkarsharma2 @pankajastro