Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add step to generate constraints in Python SDK release process #1474

Closed
kaxil opened this issue Dec 20, 2022 · 2 comments · Fixed by #1580
Closed

Add step to generate constraints in Python SDK release process #1474

kaxil opened this issue Dec 20, 2022 · 2 comments · Fixed by #1580
Assignees
Labels
documentation Improvements or additions to documentation product/python-sdk Label describing products
Milestone

Comments

@kaxil
Copy link
Collaborator

kaxil commented Dec 20, 2022

I have been manually generating constraints when I release - https://github.com/astronomer/astro-sdk/releases/tag/constraints-1.3.3

so that Cloud IDE can use it for installation. Example https://github.com/astronomer/astro/pull/7339

We should document this process in https://github.com/astronomer/astro-sdk/blob/main/python-sdk/docs/development/RELEASE.md

@kaxil kaxil added documentation Improvements or additions to documentation product/python-sdk Label describing products labels Dec 20, 2022
@kaxil kaxil self-assigned this Dec 20, 2022
@kaxil
Copy link
Collaborator Author

kaxil commented Dec 20, 2022

fyi @pankajastro @utkarsharma2 @phanikumv @sunank200

@kaxil kaxil assigned pankajastro and unassigned kaxil Jan 12, 2023
@kaxil
Copy link
Collaborator Author

kaxil commented Jan 12, 2023

The way I do it manually right now is:

  1. First I create a new branch of the last constraints branch. Example ❯ git branch constraints-1-4 constraints-1-3
  2. Checkout that branch git checkout constraints-1-4
  3. Find the Github action CI job that ran when you tagged the release and which published the artifact. In your case it was https://github.com/astronomer/astro-sdk/actions/runs/3901647585
  4. I download all the constraints file at the bottom of that GH page as shown in the screenshot below
  5. I remove old files: ❯ rm *.txt and unzip *.zip all the files and then delete zips rm *.zip
  6. Then rename them: ❯ for f in constraints*; do mv "$f" "$f.txt"; done
  7. git add const* && ❯ git commit -m "Update constraints for Astro SDK 1.4.0" --no-verify && git push origin constraints-1-4 && git tag constraints-1.4.0 && git push origin constraints-1.4.0

image

pankajastro added a commit that referenced this issue Jan 16, 2023
# Description
closes: #1474
## What is the current behavior?
Update release docs with constraints file release steps

## Does this introduce a breaking change?
No

### Checklist
- [ ] Created tests which fail without the change (if possible)
- [ ] Extended the README / documentation, if necessary

Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com>
@pankajastro pankajastro added this to the 1.4.1 milestone Jan 16, 2023
utkarsharma2 pushed a commit that referenced this issue Jan 17, 2023
# Description
closes: #1474
## What is the current behavior?
Update release docs with constraints file release steps

## Does this introduce a breaking change?
No

### Checklist
- [ ] Created tests which fail without the change (if possible)
- [ ] Extended the README / documentation, if necessary

Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com>
kaxil pushed a commit that referenced this issue Jan 20, 2023
# Description
closes: #1474
## What is the current behavior?
Update release docs with constraints file release steps

## Does this introduce a breaking change?
No

### Checklist
- [ ] Created tests which fail without the change (if possible)
- [ ] Extended the README / documentation, if necessary

Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com>
(cherry picked from commit a6d021b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation product/python-sdk Label describing products
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants