-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow community members to run the tests in a CI #179
Labels
bug
Something isn't working
ci
Continuous integration or test automation improvements
priority/critical
Critical priority
Milestone
Comments
We are in the process of refactoring our integration tests - once this is accomplished, it will be much easier to address this. |
There are 2 options here:
|
This was referenced Jul 12, 2022
kaxil
added a commit
that referenced
this issue
Jul 16, 2022
This will allow running tests on PRs from forks -- allowing outside contributors to contribute to this Repo. Committers of this repo (the one with write access) will need to add a "safe to test" label to run the tests. Until then the tests will not run. closes #179
kaxil
added a commit
that referenced
this issue
Jul 16, 2022
This will allow running tests on PRs from forks -- allowing outside contributors to contribute to this Repo. Committers of this repo (the one with write access) will need to add a "safe to test" label to run the tests. Until then the tests will not run. closes #179
kaxil
added a commit
that referenced
this issue
Jul 16, 2022
Allow running tests on PRs from forks + label This will allow running tests on PRs from forks -- allowing outside contributors to contribute to this Repo. Committers of this repo (the one with write access) will need to add a "safe to test" label to run the tests. Until then the tests will not run. closes #179 References: https://github.blog/2020-08-03-github-actions-improvements-for-fork-and-pull-request-workflows/
kaxil
added a commit
that referenced
this issue
Jul 19, 2022
Allow running tests on PRs from forks + label This will allow running tests on PRs from forks -- allowing outside contributors to contribute to this Repo. Committers of this repo (the one with write access) will need to add a "safe to test" label to run the tests. Until then the tests will not run. closes #179 References: https://github.blog/2020-08-03-github-actions-improvements-for-fork-and-pull-request-workflows/
kaxil
added a commit
that referenced
this issue
Jul 19, 2022
This will allow running tests on PRs from forks -- allowing outside contributors to contribute to this Repo. Committers of this repo (the one with write access) will need to add a "safe to test" label to run the tests. Until then the tests will not run. This is deliberate as we want to be ultra sure on who can run CI with necessary secrets closes #179 References: https://github.blog/2020-08-03-github-actions-improvements-for-fork-and-pull-request-workflows/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
ci
Continuous integration or test automation improvements
priority/critical
Critical priority
Describe the bug
At the moment, pull requests created from the community fail to run the Github tests. This happened in two PRs in the last two days:
Version
To Reproduce
Steps to reproduce the behavior:
Astro-projects/astro
astro-projects/astro
https://github.com/astro-projects/astro/runs/5463617773?check_suite_focus=true
Expected behavior
Community team members should be able to fork and create PRs and see the tests passing with no secrets issues.
The text was updated successfully, but these errors were encountered: