Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow community members to run the tests in a CI #179

Closed
tatiana opened this issue Mar 8, 2022 · 2 comments · Fixed by #546
Closed

Allow community members to run the tests in a CI #179

tatiana opened this issue Mar 8, 2022 · 2 comments · Fixed by #546
Assignees
Labels
bug Something isn't working ci Continuous integration or test automation improvements priority/critical Critical priority
Milestone

Comments

@tatiana
Copy link
Collaborator

tatiana commented Mar 8, 2022

Describe the bug
At the moment, pull requests created from the community fail to run the Github tests. This happened in two PRs in the last two days:

  1. Fix Minor Doc & Code Issues #172
  2. Use standard AWS Env Variables #176

Version

  • Astro: 0.6.0

To Reproduce
Steps to reproduce the behavior:

  1. Fork Astro-projects/astro
  2. Create a PR from the fork into astro-projects/astro
  3. See most tests failing, with messages complaining that credentials are not set, e.g.:
   File "/home/runner/work/astro/astro/.nox/test-3-8/lib/python3.8/site-packages/botocore/signers.py", line 93, in handler
    return self.sign(operation_name, request)
  File "/home/runner/work/astro/astro/.nox/test-3-8/lib/python3.8/site-packages/botocore/signers.py", line 165, in sign
    auth.add_auth(request)
  File "/home/runner/work/astro/astro/.nox/test-3-8/lib/python3.8/site-packages/botocore/auth.py", line 378, in add_auth
    raise NoCredentialsError()
botocore.exceptions.NoCredentialsError: Unable to locate credentials

https://github.com/astro-projects/astro/runs/5463617773?check_suite_focus=true

Expected behavior
Community team members should be able to fork and create PRs and see the tests passing with no secrets issues.

@tatiana tatiana added bug Something isn't working priority/critical Critical priority ci Continuous integration or test automation improvements labels Mar 8, 2022
@tatiana
Copy link
Collaborator Author

tatiana commented Mar 10, 2022

We are in the process of refactoring our integration tests - once this is accomplished, it will be much easier to address this.

@kaxil kaxil self-assigned this May 16, 2022
@kaxil kaxil added this to the 0.9.0 milestone May 16, 2022
@kaxil kaxil modified the milestones: 0.9.0, 0.10.0 May 24, 2022
@kaxil
Copy link
Collaborator

kaxil commented Jun 7, 2022

There are 2 options here:

  1. Only run unit tests (which is a larger work as currently not all integrations tests are marked as integration)
  2. Committers (one with write access to repo) can add a certain label to the PR to mark the PR as "trusted" and hence allow the PR to run tests with secrets from the CI

@kaxil kaxil modified the milestones: 0.10.0, 1.0.0 Jun 17, 2022
kaxil added a commit that referenced this issue Jul 16, 2022
This will allow running tests on PRs from forks -- allowing outside contributors to contribute to this Repo. Committers of this repo (the one with write access) will need to add a "safe to test" label to run the tests. Until then the tests will not run.

closes #179
kaxil added a commit that referenced this issue Jul 16, 2022
This will allow running tests on PRs from forks -- allowing outside contributors to contribute to this Repo. Committers of this repo (the one with write access) will need to add a "safe to test" label to run the tests. Until then the tests will not run.

closes #179
kaxil added a commit that referenced this issue Jul 16, 2022
Allow running tests on PRs from forks + label

This will allow running tests on PRs from forks -- allowing outside contributors to contribute to this Repo. Committers of this repo (the one with write access) will need to add a "safe to test" label to run the tests. Until then the tests will not run.

closes #179

References: https://github.blog/2020-08-03-github-actions-improvements-for-fork-and-pull-request-workflows/
kaxil added a commit that referenced this issue Jul 19, 2022
Allow running tests on PRs from forks + label

This will allow running tests on PRs from forks -- allowing outside contributors to contribute to this Repo. Committers of this repo (the one with write access) will need to add a "safe to test" label to run the tests. Until then the tests will not run.

closes #179

References: https://github.blog/2020-08-03-github-actions-improvements-for-fork-and-pull-request-workflows/
kaxil added a commit that referenced this issue Jul 19, 2022
This will allow running tests on PRs from forks -- allowing outside contributors to contribute to this Repo. Committers of this repo (the one with write access) will need to add a "safe to test" label to run the tests. Until then the tests will not run.

This is deliberate as we want to be ultra sure on who can run CI with necessary secrets

closes #179

References: https://github.blog/2020-08-03-github-actions-improvements-for-fork-and-pull-request-workflows/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci Continuous integration or test automation improvements priority/critical Critical priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants