Fix flaky test_example_dag[example_snowflake_partial_table_with_append] #516
Comments
This was referenced Aug 10, 2022
utkarsharma2
added a commit
that referenced
this issue
Aug 12, 2022
What is the current behavior? Quite often this test group fails to run in the CI: nox -s "test-3.8(airflow='2.3')" -- --splits 12 --group 1 --cov=src --cov-report=xml --cov-branch With: =========================== short test summary info ============================ FAILED tests/test_example_dags.py::test_example_dag[example_snowflake_partial_table_with_append] ==== 1 failed, 29 passed, 329 deselected, 22 warnings in 294.40s (0:04:54) ===== Even if there were no changes that affected this test/our code-base, for instance: #480 https://github.com/astronomer/astro-sdk/runs/7231300739 closes: #516 What is the new behavior? The issue was with SQLA's reflection cache which keeps track of the tables created and maintains all the tables in a map schema_columns[self.normalize_name(table_name)]. When this test was individually run there are no issues on local since SQLA cache is just initialized just for this test and because of which this was an intermittent issue CI. The fix is to introduce a parameter extend_existing which basically ensures the cache is not used. Ran test multiple time to ensure this is working: https://github.com/astronomer/astro-sdk/actions/runs/2832783413 Does this introduce a breaking change? Nope
kaxil
pushed a commit
that referenced
this issue
Aug 18, 2022
What is the current behavior? Quite often this test group fails to run in the CI: nox -s "test-3.8(airflow='2.3')" -- --splits 12 --group 1 --cov=src --cov-report=xml --cov-branch With: =========================== short test summary info ============================ FAILED tests/test_example_dags.py::test_example_dag[example_snowflake_partial_table_with_append] ==== 1 failed, 29 passed, 329 deselected, 22 warnings in 294.40s (0:04:54) ===== Even if there were no changes that affected this test/our code-base, for instance: #480 https://github.com/astronomer/astro-sdk/runs/7231300739 closes: #516 What is the new behavior? The issue was with SQLA's reflection cache which keeps track of the tables created and maintains all the tables in a map schema_columns[self.normalize_name(table_name)]. When this test was individually run there are no issues on local since SQLA cache is just initialized just for this test and because of which this was an intermittent issue CI. The fix is to introduce a parameter extend_existing which basically ensures the cache is not used. Ran test multiple time to ensure this is working: https://github.com/astronomer/astro-sdk/actions/runs/2832783413 Does this introduce a breaking change? Nope
josh-fell
pushed a commit
to josh-fell/astro-sdk
that referenced
this issue
Sep 3, 2022
What is the current behavior? Quite often this test group fails to run in the CI: nox -s "test-3.8(airflow='2.3')" -- --splits 12 --group 1 --cov=src --cov-report=xml --cov-branch With: =========================== short test summary info ============================ FAILED tests/test_example_dags.py::test_example_dag[example_snowflake_partial_table_with_append] ==== 1 failed, 29 passed, 329 deselected, 22 warnings in 294.40s (0:04:54) ===== Even if there were no changes that affected this test/our code-base, for instance: astronomer#480 https://github.com/astronomer/astro-sdk/runs/7231300739 closes: astronomer#516 What is the new behavior? The issue was with SQLA's reflection cache which keeps track of the tables created and maintains all the tables in a map schema_columns[self.normalize_name(table_name)]. When this test was individually run there are no issues on local since SQLA cache is just initialized just for this test and because of which this was an intermittent issue CI. The fix is to introduce a parameter extend_existing which basically ensures the cache is not used. Ran test multiple time to ensure this is working: https://github.com/astronomer/astro-sdk/actions/runs/2832783413 Does this introduce a breaking change? Nope
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Version
Describe the bug
Quite often this test group fails to run in the CI:
With:
Even if there were no changes which affected this test/our code-base, for instance:
#480
https://github.com/astronomer/astro-sdk/runs/7231300739
Expected behaviour
This test should not fail unless there is an issue with the feature tested.
The text was updated successfully, but these errors were encountered: