Consolidate doc requirements #699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaxil
requested review from
dimberman,
tatiana,
utkarsharma2,
sunank200,
pankajastro,
pankajkoti and
feluelle
as code owners
kaxil
force-pushed
the
consolidate-doc-req
branch
from
19c1b6c
to
6723206
Compare
Codecov Report
@@ Coverage Diff @@
## main #699 +/- ##
=======================================
Coverage 93.45% 93.45%
=======================================
Files 42 42
Lines 1726 1726
Branches 213 213
=======================================
Hits 1613 1613
Misses 91 91
Partials 22 22 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
feluelle
approved these changes
Aug 19, 2022
pankajkoti
reviewed
Aug 19, 2022
| @@ -97,13 +97,7 @@ def build(session: nox.Session) -> None: | |||
| @nox.session(python="3.9") | |||
| def build_docs(session: nox.Session) -> None: | |||
| """Build release artifacts.""" | |||
| session.install("sphinx") | |||
| session.install("sphinx-view") | |||
There was a problem hiding this comment.
Do we not need sphinx-view?
kaxil
added a commit
that referenced
this pull request
Aug 19, 2022
(cherry picked from commit 98ffaf8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we have 2-3 places where we put the requirements for docs, this PR consolidates it into
pyproject.toml