Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_get_credentials call in to_gbq will stop working after next major google provider release #703

Closed
feluelle opened this issue Aug 19, 2022 · 0 comments · Fixed by #717
Closed

_get_credentials call in to_gbq will stop working after next major google provider release #703

feluelle opened this issue Aug 19, 2022 · 0 comments · Fixed by #717
Assignees
@kaxil

Comments

@feluelle
Copy link
Member

The following PR got merged which changes GoogleBaseHook._get_credentials to be public i.e. GoogleBaseHook.get_credentials which will cause this line (in our bigquery load file functionality) to crash.

related: #668

The safest solution would be to already pin the version for the google cloud provider to >=6.4.0,<7.0.0 and once version 7 has been released, we can fix the reference in our code and remove the upper version limit.

cc @kaxil
@feluelle feluelle changed the title _get_credentials in bigquery load via pandas will stop working in next google provider release _get_credentials call in to_gbq will stop working after next major google provider release Aug 19, 2022
@kaxil kaxil self-assigned this Aug 22, 2022
kaxil added a commit that referenced this issue Aug 22, 2022
@kaxil
Make SDK compatible with next major version of Google Provider
70a0690 
closes #703
@kaxil kaxil mentioned this issue Aug 22, 2022
Merged
kaxil added a commit that referenced this issue Aug 23, 2022
@kaxil
Make SDK compatible with next major version of Google Provider (#717)
7d6aeb0 
closes #703
kaxil added a commit that referenced this issue Aug 23, 2022
@kaxil
Make SDK compatible with next major version of Google Provider (#717)
8d3eb1f 
closes #703

(cherry picked from commit 7d6aeb0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kaxil kaxil

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make SDK compatible with next major version of Google Provider astronomer/astro-sdk
2 participants
@kaxil @feluelle