Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to set Role at runtime #92

Closed
dimberman opened this issue Feb 8, 2022 · 0 comments · Fixed by #93
Closed

Add ability to set Role at runtime #92

dimberman opened this issue Feb 8, 2022 · 0 comments · Fixed by #93
Labels
feature New feature or request priority/critical Critical priority

Comments

@dimberman
Copy link
Collaborator

Request from Guohui:

Guohui Gao 7:53 AM
yes, currently I have a dag to load data from gcs to snowflake, I use the load_file to load to a stage database and then merge to another database table. I can use the same database or schema so I don’t need to switch roles, just wondering if there is a way to specify the role so I don’t need to change the current dag logic.

Acceptance criteria:

  • User should be able to set "role" at runtime the same way they can set database and schema
@dimberman dimberman added bug Something isn't working priority/critical Critical priority feature New feature or request and removed bug Something isn't working labels Feb 8, 2022
dimberman added a commit that referenced this issue Feb 8, 2022
@dimberman
Add ability to set role for snowflake #92
591bd30
@dimberman dimberman linked a pull request Feb 8, 2022 that will close this issue
Add ability to set role for snowflake #92 #93
Merged
dimberman added a commit that referenced this issue Feb 9, 2022
@dimberman
Add ability to set role for snowflake #92 (#93)
6b92b49
dimberman added a commit that referenced this issue Feb 10, 2022
@dimberman
Add ability to set role for snowflake #92 (#93)
eef07e7
dimberman added a commit that referenced this issue Feb 16, 2022
@dimberman
Convert templating system to feel more jinja native (#94)
00cc5ed 
* fix issue where aggregate check doesn't allow templating

* Added templating for handling identifiers

* part way to double bracket

* postgres working, snowflake is not

* Saving progress.

* rely on jinja for rendering

* raw sql working for postgres

* snowflake tests passing

* Add ability to set role for snowflake #92 (#93)

* Remove TempPostgresHook (#95)

* Remove TempPostgresHook

* more removals

* bump version

* fix boolean check

* Fixed stats check operator.

* Added custom templating logic to booleanCheck op.

* Fixed unit testcases.

* Fixed snowlake testcases.

* Fixed append operator.

* make parse work

* fix up example dags

* fix documentation

Co-authored-by: utkarsh sharma <utkarsharma@utkarshs-MacBook-Pro.local>
utkarsharma2 pushed a commit that referenced this issue Mar 30, 2022
@dimberman @utkarsharma2
Add ability to set role for snowflake #92 (#93)
e449006
utkarsharma2 pushed a commit that referenced this issue Mar 30, 2022
@dimberman @utkarsharma2
Convert templating system to feel more jinja native (#94)
67c887d 
* fix issue where aggregate check doesn't allow templating

* Added templating for handling identifiers

* part way to double bracket

* postgres working, snowflake is not

* Saving progress.

* rely on jinja for rendering

* raw sql working for postgres

* snowflake tests passing

* Add ability to set role for snowflake #92 (#93)

* Remove TempPostgresHook (#95)

* Remove TempPostgresHook

* more removals

* bump version

* fix boolean check

* Fixed stats check operator.

* Added custom templating logic to booleanCheck op.

* Fixed unit testcases.

* Fixed snowlake testcases.

* Fixed append operator.

* make parse work

* fix up example dags

* fix documentation

Co-authored-by: utkarsh sharma <utkarsharma@utkarshs-MacBook-Pro.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature or request priority/critical Critical priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add ability to set role for snowflake #92 astronomer/astro-sdk
1 participant
@dimberman