Fix transform_file to not depend on transform decorator #1004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feluelle
requested review from
dimberman,
tatiana,
utkarsharma2,
sunank200,
pankajastro and
pankajkoti
as code owners
kaxil
reviewed
Oct 6, 2022
dimberman
reviewed
Oct 6, 2022
feluelle
force-pushed
the
fix/transform-file
branch
from
a05d324
to
9e860f4
Compare
Codecov ReportBase: 93.38% // Head: 83.06% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1004 +/- ##
===========================================
- Coverage 93.38% 83.06% -10.33%
===========================================
Files 57 7 -50
Lines 2374 124 -2250
Branches 266 13 -253
===========================================
- Hits 2217 103 -2114
+ Misses 110 17 -93
+ Partials 47 4 -43 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
2 tasks
tatiana
reviewed
Oct 10, 2022
tatiana
reviewed
Oct 10, 2022
feluelle
force-pushed
the
fix/transform-file
branch
2 times, most recently
from
37be9da
to
f442d03
Compare
- use TransformOperator in transform_file - set default task_id for TransformOperator to "transform" - fix example for transform_file - resolve XComArgs when finding first table - add parameters to template_fields
feluelle
force-pushed
the
fix/transform-file
branch
from
e8892cf
to
240ba2b
Compare
dimberman
approved these changes
Oct 11, 2022
tatiana
added a commit
that referenced
this pull request
Feb 6, 2023
) Allow users to view the SQL statements, regardless of whether they are part of the DAG definition or declared on a separate file, within the Airflow UI task "Rendered Template" field. This change affects `aql.transform`, `aql.transform_file` and `aql.dataframe`, since it is implemented on the `BaseSQLDecoratedOperator`. The following changes were made: - add sql and parameters to BaseSQLDecoratedOperator template_fields - add .sql to BaseSQLDecoratedOperator template_ext - add check for template_fields and template_ext closes: #1003 depends on: #1004 Co-authored-by: Tatiana Al-Chueyr <tatiana.alchueyr@gmail.com>
utkarsharma2
pushed a commit
that referenced
this pull request
Feb 8, 2023
) Allow users to view the SQL statements, regardless of whether they are part of the DAG definition or declared on a separate file, within the Airflow UI task "Rendered Template" field. This change affects `aql.transform`, `aql.transform_file` and `aql.dataframe`, since it is implemented on the `BaseSQLDecoratedOperator`. The following changes were made: - add sql and parameters to BaseSQLDecoratedOperator template_fields - add .sql to BaseSQLDecoratedOperator template_ext - add check for template_fields and template_ext closes: #1003 depends on: #1004 Co-authored-by: Tatiana Al-Chueyr <tatiana.alchueyr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is the current behavior?
Currently, the
transform_fileis using thetransformdecorator underneath which has a few limitations. For more information check out the issue below.closes: #892
What is the new behavior?
Does this introduce a breaking change?
No.
Checklist