Fix the conn_id missing in output table #1181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunank200
requested review from
dimberman,
tatiana,
utkarsharma2,
pankajastro,
pankajkoti and
feluelle
as code owners
Codecov ReportBase: 94.43% // Head: 94.20% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1181 +/- ##
==========================================
- Coverage 94.43% 94.20% -0.23%
==========================================
Files 16 68 +52
Lines 521 3140 +2619
Branches 51 358 +307
==========================================
+ Hits 492 2958 +2466
- Misses 20 120 +100
- Partials 9 62 +53
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
phanikumv
force-pushed
the
fix-transform-ol
branch
from
33901fe
to
6f543e8
Compare
rajaths010494
force-pushed
the
fix-transform-ol
branch
from
6f543e8
to
dab2786
Compare
rajaths010494
force-pushed
the
fix-transform-ol
branch
from
8f65aaf
to
ce333ae
Compare
pankajastro
reviewed
Nov 4, 2022
pankajastro
force-pushed
the
fix-transform-ol
branch
from
7d800eb
to
cd9e293
Compare
pankajastro
force-pushed
the
fix-transform-ol
branch
from
b8f16af
to
aff7612
Compare
phanikumv
approved these changes
Nov 4, 2022
utkarsharma2
pushed a commit
that referenced
this pull request
Nov 4, 2022
# Description ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> `conn_id` is missing in output table for transform operator. It should be checked for that <!-- Issues are required for both bug fixes and features. Reference it using one of the following: closes: #ISSUE related: #ISSUE --> closes: #1152 ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Check if `conn_id` is empty - Push row count of output table to xcom - Fixed some flaky test ## Does this introduce a breaking change? No ### Checklist - [x] Created tests which fail without the change (if possible) - [x] Extended the README / documentation, if necessary Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: rajaths010494 <rajath.srinivasaiah@astronomer.io> Co-authored-by: Pankaj Singh <98807258+pankajastro@users.noreply.github.com> Co-authored-by: Pankaj <pankaj.singh@astronomer.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is the current behavior?
conn_idis missing in output table for transform operator. It should be checked for thatcloses: #1152
What is the new behavior?
conn_idis emptyDoes this introduce a breaking change?
No
Checklist