-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass task_id to be used for parent class on LoadFileOperator initialisation #1259
Conversation
…sation The SQL CLI render task for the load_file interface when calling LoadFileOperator needs task_id to be available as part of the initialisation, hence generate a task_id if it is not provided already and pass it to the parent class for initialisation.
Also, isn't it possible to add task_id as part of I think the change you propose has the benefit of not having to set it i.e. by setting a default. But it should also work by explicitly setting it, no? |
Codecov ReportBase: 94.13% // Head: 94.13% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #1259 +/- ##
=======================================
Coverage 94.13% 94.13%
=======================================
Files 17 17
Lines 597 597
Branches 67 67
=======================================
Hits 562 562
Misses 22 22
Partials 13 13 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
yes, like we tested, we can pass it from SQL CLI too, and it is good to have this in the operator too that this PR implements. |
Address @feluelle's review comment
67c7546
to
05cf11f
Compare
…sation (#1259) The SQL CLI render task for the load_file interface when calling LoadFileOperator needs task_id to be available as part of the initialisation, hence generate a task_id if it is not provided already and pass it to the parent class for initialisation. ## Does this introduce a breaking change? No Issue screenshot: <img width="1657" alt="Screenshot 2022-11-16 at 10 12 26 PM" src="https://user-images.githubusercontent.com/10206082/202240926-fe4250b8-c0db-4d37-97ca-1266fc68eb91.png"> (cherry picked from commit 392a450)
…sation (#1259) The SQL CLI render task for the load_file interface when calling LoadFileOperator needs task_id to be available as part of the initialisation, hence generate a task_id if it is not provided already and pass it to the parent class for initialisation. No Issue screenshot: <img width="1657" alt="Screenshot 2022-11-16 at 10 12 26 PM" src="https://user-images.githubusercontent.com/10206082/202240926-fe4250b8-c0db-4d37-97ca-1266fc68eb91.png">
The SQL CLI render task for the load_file interface when calling LoadFileOperator needs task_id to be available
as part of the initialisation, hence generate a task_id if it is not provided already and pass it to the parent class for initialisation.
Does this introduce a breaking change?
No
Issue screenshot:
![Screenshot 2022-11-16 at 10 12 26 PM](https://user-images.githubusercontent.com/10206082/202240926-fe4250b8-c0db-4d37-97ca-1266fc68eb91.png)