-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug with datetime not being serialized #1334
Conversation
Codecov ReportBase: 95.71% // Head: 94.68% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1334 +/- ##
==========================================
- Coverage 95.71% 94.68% -1.04%
==========================================
Files 19 74 +55
Lines 677 3516 +2839
Branches 68 401 +333
==========================================
+ Hits 648 3329 +2681
- Misses 18 114 +96
- Partials 11 73 +62
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will need to correct the assert in the tests here:
assert s_df == {"id": {0: 1}, "name": {0: "xyz"}} |
to assert s_df == {"data": {"id": {0: 1}, "name": {0: "xyz"}}}
Also look like the tests are not running for that file as the file name is missing the test_
prefix, we will need to rename it to test_pandas.py
and hence codecoverage is reporting that the patched lines are not covered
af92bbc
to
d45598f
Compare
Airflow's XCom still can't serialize datetime, set and other types, so we can't use
Added pre-commit hook so that we detect such cases :) |
Since Airflow still doesn't support serializing sets or datetime, it would be better to serialize dataframes to string instead of dict. This PR also adds pre-commit hook so we don't miss `test_` prefix in the test files (cherry picked from commit 8fd6cdd)
Since Airflow still doesn't support serializing sets or datetime, it would be better to serialize dataframes to string instead of dict.
This PR also adds pre-commit hook so we don't miss
test_
prefix in the test files