-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the ability load files using autoloader #1452
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 97.36% // Head: 97.36% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #1452 +/- ##
=======================================
Coverage 97.36% 97.36%
=======================================
Files 19 19
Lines 682 682
=======================================
Hits 664 664
Misses 18 18 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
dimberman
requested review from
tatiana,
utkarsharma2,
sunank200,
pankajastro,
pankajkoti and
feluelle
as code owners
December 19, 2022 22:12
dimberman
force-pushed
the
databricks/add-autoloader
branch
from
December 19, 2022 22:14
00f1f49
to
0400651
Compare
kaxil
reviewed
Dec 19, 2022
feluelle
reviewed
Dec 20, 2022
python-sdk/tests/databricks/load_file/test_load_python_code_generator.py
Outdated
Show resolved
Hide resolved
python-sdk/tests/databricks/load_file/test_load_python_code_generator.py
Outdated
Show resolved
Hide resolved
…atabricks/add-autoloader
Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com> Co-authored-by: Felix Uellendall <feluelle@users.noreply.github.com>
…omer/astro-sdk into databricks/add-autoloader
…omer/astro-sdk into databricks/add-autoloader
feluelle
approved these changes
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is the current behavior?
Currently all loading is done via the COPY INTO command. This command can work fine on small to mid-sized datasets but falls short when dealing with very large datasets. It also does not have a lot of popular autoloader features such as incremental loading.
CLOSES: #1445
What is the new behavior?
Now the user will by default use autoloader unless a) they set the
load_options.load_mode
to COPY INTO or b) they load a single file (since autoloader can not handle single files).Does this introduce a breaking change?
Checklist