Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate constraints on releases and pushes (not PRs) #1472

Merged
merged 1 commit into from
Dec 20, 2022
Merged

Conversation

kaxil
Copy link
Collaborator

@kaxil kaxil commented Dec 20, 2022

This will limit generating constraints on releases and pushes (not PRs). I don't think we need to generate constraints on every PR

This will limit generating constraints on releases and pushes (not PRs). I don't think we need to generate constraints on every PR
@@ -364,6 +364,7 @@ jobs:
AZURE_WASB_CONN_STRING: ${{ secrets.AZURE_WASB_CONN_STRING }}

Generate-Constraints:
if: (github.event_name == 'release' || github.event_name == 'push')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to check that the push is on main branch?
I see the the action is skipped here but is it that the commit was pushed first and then the pull request was created and hence it got skipped. What if we push a commit to an existing pull request? Will it skip then also?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We restrict pushes on main and release branches only in the following block

on:
push:
branches: [ 'main', 'release-**' ]

Hence it won't send push event for other branches to this job

@codecov
Copy link

codecov bot commented Dec 20, 2022

Codecov Report

Base: 92.90% // Head: 97.32% // Increases project coverage by +4.41% 🎉

Coverage data is based on head (f5dddc7) compared to base (fa654a6).
Patch has no changes to coverable lines.

❗ Current head f5dddc7 differs from pull request most recent head 50257f9. Consider uploading reports for the commit 50257f9 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1472      +/-   ##
==========================================
+ Coverage   92.90%   97.32%   +4.41%     
==========================================
  Files          61       19      -42     
  Lines        3215      672    -2543     
  Branches      382        0     -382     
==========================================
- Hits         2987      654    -2333     
+ Misses        151       18     -133     
+ Partials       77        0      -77     
Impacted Files Coverage Δ
python-sdk/src/astro/sql/operators/dataframe.py
python-sdk/src/astro/files/operators/files.py
python-sdk/src/astro/sql/operators/append.py
python-sdk/src/astro/files/locations/local.py
python-sdk/src/astro/databases/base.py
python-sdk/src/astro/files/types/base.py
python-sdk/src/astro/sql/operators/drop.py
...thon-sdk/src/astro/sql/operators/base_decorator.py
python-sdk/src/astro/files/locations/google/gcs.py
...dk/src/astro/sql/operators/export_table_to_file.py
... and 70 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kaxil
Copy link
Collaborator Author

kaxil commented Dec 20, 2022

Failures are unrelated, merging

@kaxil kaxil merged commit cf81056 into main Dec 20, 2022
@kaxil kaxil deleted the ge-constraints branch December 20, 2022 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants