Support for FTP as file location #1482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 97.43% // Head: 93.16% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1482 +/- ##
==========================================
- Coverage 97.43% 93.16% -4.27%
==========================================
Files 21 65 +44
Lines 740 3481 +2741
Branches 0 418 +418
==========================================
+ Hits 721 3243 +2522
- Misses 19 157 +138
- Partials 0 81 +81 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
9 tasks
rajaths010494
requested review from
dimberman,
tatiana,
utkarsharma2,
sunank200,
pankajastro,
pankajkoti,
feluelle and
kaxil
as code owners
rajaths010494
changed the title
|
I think we should also support export_file() operator. |
phanikumv
reviewed
Dec 23, 2022
sunank200
reviewed
Dec 23, 2022
|
@rajaths010494 there should be tests for export file as well which are required to be added for FTP. |
pankajastro
reviewed
Dec 23, 2022
feluelle
reviewed
Dec 25, 2022
pankajastro
requested review from
sunank200,
utkarsharma2,
feluelle,
pankajastro and
phanikumv
rajaths010494
force-pushed
the
ftp_location
branch
2 times, most recently
from
3c8702d
to
65cdae4
Compare
added integration test case for export and read the content and assert it |
FTP support file location
rajaths010494
force-pushed
the
ftp_location
branch
from
6594840
to
5b23a9f
Compare
sunank200
reviewed
Jan 4, 2023
sunank200
approved these changes
Jan 5, 2023
utkarsharma2
pushed a commit
that referenced
this pull request
Jan 17, 2023
relates-to #969 **Please describe the feature you'd like to see** It is a very common ETL operation to either push data to or load data from FTP sources **Describe the solution you'd like** FTP should be valid location types in `File` **Are there any alternatives to this feature?** Implementors otherwise need to use workarounds like `S3toSFTPOperator` **Acceptance Criteria** - [x] All checks and tests in the CI should pass - [x] Unit tests (90% code coverage or more, [once available](#191)) - [x] Integration tests (if the feature relates to a new database or external service) - [x] Example DAG - [x] Docstrings in [reStructuredText](https://peps.python.org/pep-0287/) for each of methods, classes, functions and module-level attributes (including Example DAG on how it should be used) - [x] Exception handling in case of errors - [x] Logging (are we exposing useful information to the user? e.g. source and destination) - [x] Improve the documentation (README, Sphinx, and any other relevant) - [x] How to use Guide for the feature ([example](https://airflow.apache.org/docs/apache-airflow-providers-postgres/stable/operators/postgres_operator_howto_guide.html))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates-to #969
Please describe the feature you'd like to see
It is a very common ETL operation to either push data to or load data from FTP sources
Describe the solution you'd like
FTP should be valid location types in
FileAre there any alternatives to this feature?
Implementors otherwise need to use workarounds like
S3toSFTPOperatorAcceptance Criteria