Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate export_table_to_file to export_to_file #1503

Merged
merged 6 commits into from
Jan 5, 2023

Conversation

pankajastro
Copy link
Contributor

@pankajastro pankajastro commented Dec 30, 2022

Description

closes: #1530
Related to: https://astronomer.slack.com/archives/C03868KGF2Q/p1671621286602989

What is the current behavior?

Recently, we deprecated export_file to export_table_to_file but looks like export_to_file is a better name fit for this

What is the new behavior?

Deprecate to export_table_to_file to export_to_file

Does this introduce a breaking change?

Checklist

  • Created tests which fail without the change (if possible)
  • Extended the README / documentation, if necessary

@codecov
Copy link

codecov bot commented Dec 30, 2022

Codecov Report

Base: 93.67% // Head: 93.87% // Increases project coverage by +0.19% 🎉

Coverage data is based on head (12cee44) compared to base (6d6ca44).
Patch coverage: 98.36% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1503      +/-   ##
==========================================
+ Coverage   93.67%   93.87%   +0.19%     
==========================================
  Files          84       86       +2     
  Lines        4082     4193     +111     
  Branches      404      416      +12     
==========================================
+ Hits         3824     3936     +112     
+ Misses        177      176       -1     
  Partials       81       81              
Impacted Files Coverage Δ
...thon-sdk/src/astro/sql/operators/export_to_file.py 97.95% <97.95%> (ø)
python-sdk/src/astro/sql/__init__.py 96.00% <100.00%> (+0.16%) ⬆️
python-sdk/src/astro/sql/operators/export_file.py 100.00% <100.00%> (ø)
...dk/src/astro/sql/operators/export_table_to_file.py 100.00% <100.00%> (+2.04%) ⬆️
python-sdk/src/astro/exceptions.py 100.00% <0.00%> (ø)
python-sdk/src/astro/files/base.py 100.00% <0.00%> (ø)
sql-cli/sql_cli/dag_render.py
sql-cli/sql_cli/run_dag.py
sql-cli/sql_cli/dag_renderer.py 100.00% <0.00%> (ø)
sql-cli/sql_cli/dag_runner.py 97.82% <0.00%> (ø)
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pankajastro pankajastro changed the title Rename export_table_to_file to export_to_file Rename export_table_to_file to export_to_file Jan 3, 2023
@pankajastro pankajastro marked this pull request as ready for review January 3, 2023 11:15
@pankajastro pankajastro added this to the 1.4.0 milestone Jan 3, 2023
Copy link
Collaborator

@tatiana tatiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pankajastro since this task allows users to export both from SQL tables to file and from Pandas Dataframes to file, the change is relevant and essential. Ideally, this should be part of 1.4.

The one open question is whether we want a smooth transition to deprecate it (my +1) or to make this change more abrupt.

@pankajastro pankajastro changed the title Rename export_table_to_file to export_to_file Deprecate export_table_to_file to export_to_file Jan 4, 2023
Copy link
Collaborator

@tatiana tatiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @pankajastro, for adding the deprecation warning - and I'm very sorry for not being more critical of the previous PR. No more renaming of this task for the next 2 releases at least 😂

@pankajastro pankajastro merged commit 189f198 into main Jan 5, 2023
@pankajastro pankajastro deleted the rename_export_file branch January 5, 2023 11:22
utkarsharma2 pushed a commit that referenced this pull request Jan 17, 2023
# Description
closes: #1530
Related to:
https://astronomer.slack.com/archives/C03868KGF2Q/p1671621286602989

## What is the current behavior?
Recently, we deprecated `export_file` to `export_table_to_file` but
looks like `export_to_file` is a better name fit for this


## What is the new behavior?
Deprecate  to `export_table_to_file` to  `export_to_file` 

## Does this introduce a breaking change?


### Checklist
- [ ] Created tests which fail without the change (if possible)
- [ ] Extended the README / documentation, if necessary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate export_table_to_file to export_to_file
4 participants