-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate export_table_to_file
to export_to_file
#1503
Conversation
Codecov ReportBase: 93.67% // Head: 93.87% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1503 +/- ##
==========================================
+ Coverage 93.67% 93.87% +0.19%
==========================================
Files 84 86 +2
Lines 4082 4193 +111
Branches 404 416 +12
==========================================
+ Hits 3824 3936 +112
+ Misses 177 176 -1
Partials 81 81
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
export_table_to_file
to export_to_file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pankajastro since this task allows users to export both from SQL tables to file and from Pandas Dataframes to file, the change is relevant and essential. Ideally, this should be part of 1.4.
The one open question is whether we want a smooth transition to deprecate it (my +1) or to make this change more abrupt.
58192a4
to
e3dac03
Compare
for more information, see https://pre-commit.ci
export_table_to_file
to export_to_file
export_table_to_file
to export_to_file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @pankajastro, for adding the deprecation warning - and I'm very sorry for not being more critical of the previous PR. No more renaming of this task for the next 2 releases at least 😂
# Description closes: #1530 Related to: https://astronomer.slack.com/archives/C03868KGF2Q/p1671621286602989 ## What is the current behavior? Recently, we deprecated `export_file` to `export_table_to_file` but looks like `export_to_file` is a better name fit for this ## What is the new behavior? Deprecate to `export_table_to_file` to `export_to_file` ## Does this introduce a breaking change? ### Checklist - [ ] Created tests which fail without the change (if possible) - [ ] Extended the README / documentation, if necessary
Description
closes: #1530
Related to: https://astronomer.slack.com/archives/C03868KGF2Q/p1671621286602989
What is the current behavior?
Recently, we deprecated
export_file
toexport_table_to_file
but looks likeexport_to_file
is a better name fit for thisWhat is the new behavior?
Deprecate to
export_table_to_file
toexport_to_file
Does this introduce a breaking change?
Checklist