Add support to load from Azure blob storage into Databricks #1561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tatiana
commented
Jan 10, 2023
tatiana
changed the title
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1561 +/- ##
==========================================
+ Coverage 86.35% 86.42% +0.06%
==========================================
Files 126 126
Lines 6786 6813 +27
Branches 670 672 +2
==========================================
+ Hits 5860 5888 +28
+ Misses 779 778 -1
Partials 147 147
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
tatiana
commented
Jan 10, 2023
tatiana
changed the title
tatiana
force-pushed
the
python-sdk/1250
branch
2 times, most recently
from
9064b44
to
93af85d
Compare
dimberman
requested changes
Feb 13, 2023
There was a problem hiding this comment.
Hey @tatiana this looks great! Also fantastic that we can add new sources by just adding one function :). Can you please add an example DAG and update the documentation to discuss any steps a user would need to take to load data from Azure?
dimberman
reviewed
Feb 13, 2023
dimberman
approved these changes
Feb 16, 2023
tatiana
force-pushed
the
python-sdk/1250
branch
2 times, most recently
from
603389e
to
8cd01ea
Compare
tatiana
force-pushed
the
python-sdk/1250
branch
from
31fdaaa
to
07c675f
Compare
tatiana
force-pushed
the
python-sdk/1250
branch
from
07c675f
to
c5d4b00
Compare
There is a deeper problem at the moment, in the sense that oure tests/implementation rely on things being setup in the cluster in advance. In gcs, this means: - spark.hadoop.fs.gs.auth.service.account.email - spark.hadoop.fs.gs.project.id - spark.hadoop.google.cloud.auth.service.account.enable - spark.hadoop.fs.gs.auth.service.account.private.key - spark.hadoop.fs.gs.auth.service.account.private.key.id
tatiana
requested review from
utkarsharma2,
sunank200,
pankajastro,
pankajkoti and
feluelle
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1250