-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a results_format field to run_raw_sql #1584
Conversation
Codecov ReportBase: 97.72% // Head: 92.95% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1584 +/- ##
==========================================
- Coverage 97.72% 92.95% -4.78%
==========================================
Files 21 89 +68
Lines 835 4570 +3735
Branches 0 450 +450
==========================================
+ Hits 816 4248 +3432
- Misses 19 230 +211
- Partials 0 92 +92
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address my comments around logs, docs, example DAGs and then feel free to merge
6d080e1
to
9d6211d
Compare
Description
related: #1583
This PR extends the
run_raw_sql
to make it easier to get results. Previously, you'd have to write ahandler
yourself. The idea behind this change is to abstract some of the common handlers (get the results as a list, dataframe).Specifically, it:
results_format
: let the user specify a common format they want their results (list, dataframe)fail_on_empty
: let the user decide what the behavior should be if there are no resultsDoes this introduce a breaking change?
No, everything is incremental
Checklist