Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Python SDK README quickstart #1716

Merged
merged 1 commit into from
Feb 6, 2023
Merged

Conversation

tatiana
Copy link
Collaborator

@tatiana tatiana commented Feb 6, 2023

Previously, if someone tried to run the quickstart example described in the Python SDK README, it would not work out of the box, due to two problems:

  1. The curl command was referencing a file that did not exist
  2. The environment variables we were setting were not enough

This PR addresses these issues, also explaining the limitations of the proposed environment variable setup and pointing to how to setup in a non-local environment.

@sunank200 sunank200 added this to the 1.5.0 milestone Feb 6, 2023
@tatiana tatiana merged commit 2fa5098 into main Feb 6, 2023
@tatiana tatiana deleted the python-sdk/readme-improvement branch February 6, 2023 11:50
@utkarsharma2
Copy link
Collaborator

I think it would be better if we include this dags in the example dag and refer here using permalinks

utkarsharma2 pushed a commit that referenced this pull request Feb 8, 2023
Previously, if someone tried to run the quickstart example described in
the Python SDK README, it would not work out of the box, due to two
problems:
1. The curl command was referencing a file that did not exist
2. The environment variables we were setting were not enough

This PR addresses these issues, also explaining the limitations of the
proposed environment variable setup and pointing to how to setup in a
non-local environment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants