Fix CI - pandas-gbq dependency issue #1768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utkarsharma2
requested review from
dimberman,
tatiana,
sunank200,
pankajastro,
pankajkoti and
feluelle
as code owners
Codecov ReportBase: 93.20% // Head: 97.72% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1768 +/- ##
==========================================
+ Coverage 93.20% 97.72% +4.51%
==========================================
Files 91 21 -70
Lines 4845 835 -4010
Branches 479 0 -479
==========================================
- Hits 4516 816 -3700
+ Misses 238 19 -219
+ Partials 91 0 -91 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
tatiana
approved these changes
Feb 16, 2023
There was a problem hiding this comment.
Thanks, @utkarsharma2 ! Dependency hell 🙈
Happy for this to be merged once the checks pass!
pankajastro
approved these changes
Feb 16, 2023
|
The failing tests are not relevant to this PR. Going ahead and merging it. |
2 tasks
utkarsharma2
added a commit
that referenced
this pull request
Feb 21, 2023
# Description ## What is the current behavior? version: 0.13.2 of pandas-gbq is installed on CI containers causing it to fail. 1. Exception not found 2. pandas - 1.5.3 is not compatible 0.13.2 closes: #1761 ## What is the new behavior? We found out that the snowflake-connector-python is using pyarrow which uses google packages and pandas-gbq uses the same google packages due to which the 0.13.2 of pandas was getting installed. ## Does this introduce a breaking change? Nope ### Checklist - [ ] Created tests which fail without the change (if possible) - [ ] Extended the README / documentation, if necessary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is the current behavior?
version: 0.13.2 of pandas-gbq is installed on CI containers causing it to fail.
closes: #1761
What is the new behavior?
We found out that the snowflake-connector-python is using pyarrow which uses google packages and pandas-gbq uses the same google packages due to which the 0.13.2 of pandas was getting installed.
Does this introduce a breaking change?
Nope
Checklist