Allow aql.transform to receive sql filepath (fix breaking change)
#1879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tatiana
added
product/python-sdk
tatiana
changed the title
aql.transform to receive sql filepath (fix breaking change)
tatiana
force-pushed
the
fix-maggie-bug
branch
2 times, most recently
from
6218ba0
to
ceec0ab
Compare
tatiana
force-pushed
the
fix-maggie-bug
branch
2 times, most recently
from
b94787e
to
86f33dd
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1879 +/- ##
=======================================
Coverage 86.42% 86.42%
=======================================
Files 126 126
Lines 6813 6814 +1
Branches 672 672
=======================================
+ Hits 5888 5889 +1
Misses 778 778
Partials 147 147
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
tatiana
requested review from
dimberman,
utkarsharma2,
sunank200,
pankajastro and
pankajkoti
as code owners
|
@tatiana, Thanks for creating the PR with a very clear test case. I'm sure didn't we have this scenario in our tests leading to this situation. IMO, we should be backward compatible and should only introduce breaking changes in 2.0. WDYT? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
aql.transformbreaking change (pass a.sqlfile to thesqlargument).This PR contains:
aql.transform, which raises an exception in 1.5.3 (and used to work in 1.3.3)Astronomer's Data team raised this issue in an internal slack: https://astronomer.slack.com/archives/C02B.8SPT93K/p1680202480707669
The alternative to this solution is to use
aql.transform_file. However, since this feature was working before and stopped working between minor releases, we opted to fix it as well.