Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve example_load_file DAG tasks names #1958

Merged
merged 2 commits into from
Jun 6, 2023

Conversation

vatsrahul1001
Copy link
Collaborator

@vatsrahul1001 vatsrahul1001 commented Jun 6, 2023

Description

What is the current behavior?

Currently, task names in example_load_file DAG are not provided due to which there sequence changes at runtime also task names are not descriptive

What is the new behavior?

  1. adding task_id field in all the tasks
  2. adding logical names for the tasks for better readability
  3. Noticed a few tasks were duplicates, so removed them

Copy link
Collaborator

@tatiana tatiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @vatsrahul1001 , this will help users visualising the different load names. I'm happy for the change to be merged once the checks pass!

@tatiana tatiana changed the title updating tasks name in example_load_file DAG Improve example_load_file DAG tasks names Jun 6, 2023
@vatsrahul1001
Copy link
Collaborator Author

vatsrahul1001 commented Jun 6, 2023

Thanks, @vatsrahul1001 , this will help users visualising the different load names. I'm happy for the change to be merged once the checks pass!

thanks to @utkarsharma2 for helping me out in giving logical names to tasks

@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.47 🎉

Comparison is base (bbb4541) 91.69% compared to head (ff03597) 92.16%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1958      +/-   ##
==========================================
+ Coverage   91.69%   92.16%   +0.47%     
==========================================
  Files          72       72              
  Lines        4250     4250              
  Branches      511      511              
==========================================
+ Hits         3897     3917      +20     
+ Misses        257      240      -17     
+ Partials       96       93       -3     
Flag Coverage Δ
PythonSDK 92.16% <ø> (+0.47%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vatsrahul1001 vatsrahul1001 merged commit 8d9e807 into main Jun 6, 2023
31 checks passed
@vatsrahul1001 vatsrahul1001 deleted the rename_example_load_file_tasks_name branch June 6, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants