Add support for pandas 2.0 #1983
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimberman
requested review from
tatiana,
utkarsharma2,
sunank200 and
pankajastro
as code owners
tatiana
reviewed
Jul 11, 2023
There was a problem hiding this comment.
@dimberman happy for us to merge this once the checks are passing.
It seems the new pandas are breaking:
FAILED tests_integration/test_example_dags.py::test_example_dag[example_sqlite_load_transform] - TypeError: __init__() got an unexpected keyword argument 'engine'
2 tasks
|
I think we can close this one since #1989 has merged cc @utkarsharma2 |
|
Closing this, since it was part of this other PR, which was already merged: #1989 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we have not found any breaking changes with pandas 2.0, lets offer 2.0 support for users who wish to use the latest pandas can offer.
In creating this PR, we also tested whether or not we could upgrade the snowflake python connector, but unfortunately we ran into the same versioning issue as before.