Unpin pandas upperbound dependency #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #620 +/- ##
=======================================
Coverage 93.30% 93.30%
=======================================
Files 41 41
Lines 1672 1672
Branches 211 211
=======================================
Hits 1560 1560
Misses 89 89
Partials 23 23
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
kaxil
reviewed
Aug 9, 2022
| @@ -16,7 +16,7 @@ requires-python = ">=3.7" | |||
| dependencies = [ | |||
| "apache-airflow>=2.0", | |||
| "markupsafe>=1.1.1,<2.1.0", | |||
There was a problem hiding this comment.
Worth investigating in a separate PR/issue if we can remove markupsafe
There was a problem hiding this comment.
@kaxil I'll create a ticket for the same. Should it be part of this sprint?
utkarsharma2
changed the title
kaxil
approved these changes
Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is the current behavior?
We have pinned Pandas library
astro-sdk/pyproject.toml
Line 19 in 6b90c92
"pandas>=1.3.4,<=1.3.5",
This was done in #130 but a lot of things have changed since. Let's investigate if this pin (upper bound) is still required.
Related Slack thread: https://astronomer.slack.com/archives/C03868KGF2Q/p1659546153698379?thread_ts=1659545419.511649&cid=C03868KGF2Q
closes: #604
What is the new behavior?
unpinned the upper bound of pandas dependency
Does this introduce a breaking change?
Nope