Use lazy evaluated Type Annotations from PEP 563 #650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaxil
requested review from
dimberman,
tatiana,
utkarsharma2,
sunank200,
pankajastro,
pankajkoti and
feluelle
as code owners
|
Also credits to @tatiana she brought it up first in #384 (comment) |
kaxil
force-pushed
the
use-new-annotations
branch
2 times, most recently
from
0163466
to
9f60b12
Compare
|
There are some caveats though as listed in https://mypy.readthedocs.io/en/stable/runtime_troubles.html#future-annotations-import-pep-563. @uranusjr Is it safe to use this or should we wait till we drop support for Python 3.7 and 3.8? |
Codecov Report
@@ Coverage Diff @@
## main #650 +/- ##
==========================================
+ Coverage 92.47% 93.00% +0.52%
==========================================
Files 42 42
Lines 1701 1715 +14
Branches 216 212 -4
==========================================
+ Hits 1573 1595 +22
+ Misses 102 98 -4
+ Partials 26 22 -4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
uranusjr
reviewed
Aug 13, 2022
uranusjr
approved these changes
Aug 13, 2022
feluelle
approved these changes
Aug 16, 2022
|
There are a couple of suggestions from They are unrelated to this PR but should we fix them as part of this PR? |
Details: https://peps.python.org/pep-0563/ and https://discuss.python.org/t/type-annotations-pep-649-and-pep-563/11363/20 tl_dr: This PEP lazy evaluates Annotations so they are not evaluated at parse time and allows forward references as well. This also includes https://peps.python.org/pep-0604/ which allows writing typing.Union[int, str]` as `int | str` and includes https://peps.python.org/pep-0585/ which allows us to write `def f(x: List[str]) -> None` to `def f(x: list[str]) -> None`
kaxil
force-pushed
the
use-new-annotations
branch
from
52d9389
to
674f2fa
Compare
kaxil
added a commit
that referenced
this pull request
Aug 18, 2022
Details: https://peps.python.org/pep-0563/ and https://discuss.python.org/t/type-annotations-pep-649-and-pep-563/11363/20 tl_dr: This PEP lazy evaluates Annotations so they are not evaluated at parse time and allows forward references as well. This also includes https://peps.python.org/pep-0604/ which allows writing §typing.Union[int, str]` as `int | str` and includes https://peps.python.org/pep-0585/ which allows us to write `def f(x: List[str]) -> None` to `def f(x: list[str]) -> None`
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details: https://peps.python.org/pep-0563/ and https://discuss.python.org/t/type-annotations-pep-649-and-pep-563/11363/20
tl_dr: This PEP lazy evaluates Annotations so they are not evaluated at parse time and allows forward references as well.
This also includes https://peps.python.org/pep-0604/ which allows writing
typing.Union[int, str]asint | strand includes https://peps.python.org/pep-0585/ which allows us to writedef f(x: List[str]) -> Nonetodef f(x: list[str]) -> None