Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add get_value_list for Dynamic Task #673

Merged
merged 22 commits into from
Sep 7, 2022
Merged

Add get_value_list for Dynamic Task #673

merged 22 commits into from
Sep 7, 2022

Conversation

pankajastro
Copy link
Contributor

@pankajastro pankajastro commented Aug 17, 2022 •
edited
Loading

Description

Add operator RunQueryOperator which takes a SQL stmt as input and returns its result

closes: #658

@pankajastro pankajastro force-pushed the dtt_get_value_list branch 2 times, most recently from e3803dd to 0a77bbb Compare August 18, 2022 15:37
@pankajastro pankajastro requested a review from kaxil August 18, 2022 16:30
@pankajastro pankajastro marked this pull request as ready for review August 18, 2022 16:30
feluelle
feluelle reviewed Aug 19, 2022
View reviewed changes
src/astro/sql/__init__.py Outdated Show resolved Hide resolved
sunank200
sunank200 reviewed Aug 19, 2022
View reviewed changes
Copy link
Contributor

@sunank200 sunank200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added few comments

src/astro/sql/__init__.py Outdated Show resolved Hide resolved
src/astro/sql/operators/load_table.py Outdated Show resolved Hide resolved
tests/sql/operators/test_load_table.py Outdated Show resolved Hide resolved
tests/sql/operators/test_load_table.py Outdated Show resolved Hide resolved
@pankajastro pankajastro force-pushed the dtt_get_value_list branch 3 times, most recently from 5ba5099 to b7b7665 Compare August 26, 2022 08:33
@codecov
Copy link

codecov bot commented Aug 29, 2022 •
edited
Loading

Codecov Report

Merging #673 (d03a9e0) into main (1f5f16c) will increase coverage by 0.05%.
The diff coverage is 93.33%.

@@            Coverage Diff             @@
##             main     #673      +/-   ##
==========================================
+ Coverage   93.26%   93.31%   +0.05%     
==========================================
  Files          43       43              
  Lines        1855     1869      +14     
  Branches      232      234       +2     
==========================================
+ Hits         1730     1744      +14     
  Misses         97       97              
  Partials       28       28
Impacted Files Coverage Δ
python-sdk/src/astro/sql/__init__.py 95.00% <90.00%> (-5.00%) ⬇️
...thon-sdk/src/astro/sql/operators/base_decorator.py 94.05% <100.00%> (+1.05%) ⬆️
python-sdk/src/astro/sql/operators/raw_sql.py 86.36% <100.00%> (+2.15%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

utkarsharma2
utkarsharma2 approved these changes Aug 30, 2022
View reviewed changes
Copy link
Collaborator

@utkarsharma2 utkarsharma2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pankajastro LGTM

pankajastro
pankajastro commented Sep 1, 2022
View reviewed changes
tests/sql/test_table.py Outdated Show resolved Hide resolved
@pankajastro pankajastro force-pushed the dtt_get_value_list branch 2 times, most recently from c37cf39 to 0b7e9ad Compare September 1, 2022 15:27
@pankajastro pankajastro force-pushed the dtt_get_value_list branch 3 times, most recently from 03d4e93 to 35a32df Compare September 6, 2022 14:53
pankajastro and others added 22 commits September 7, 2022 02:12
@pankajastro
Add operator for get_value_list dtt
e20096f
@pankajastro
Fix test
dda318d
@pre-commit-ci @pankajastro
[pre-commit.ci] auto fixes from pre-commit.com hooks
9eea701 
for more information, see https://pre-commit.ci
@pankajastro
Fix deepsource check
db3ef88
@pankajastro
Fix integration test
b33bb0d
@pankajastro
Dummy commit
ef25022
@pankajastro
Dummy commit
4ac1a01
@pankajastro
Fix integration test
2641af9
@pankajastro
Remove print stmt
d1526a0
@pankajastro
Fix test cov
1a34e19
@pankajastro
Improve docs
0191203
@pankajastro
Improve docs
b24729a
@pankajastro
Fix test
7da01c1
@pankajastro
Reuse RawSQLOperator
e46c543
@pre-commit-ci @pankajastro
[pre-commit.ci] auto fixes from pre-commit.com hooks
f8e71d4 
for more information, see https://pre-commit.ci
@pankajastro
Fix test
b041177
@pankajastro
Pass dummy python_callable
bb10589
@pankajastro
Fix test
dd07c72
@pankajastro
fix task_id
2bbd6a2
@pre-commit-ci @pankajastro
[pre-commit.ci] auto fixes from pre-commit.com hooks
4afc3a1 
for more information, see https://pre-commit.ci
@pankajastro
Typecast conf value
8e8ede6
@pankajastro
Remove RunQueryOperator
d03a9e0
@pankajastro pankajastro mentioned this pull request Sep 6, 2022
Closed
@pankajastro pankajastro merged commit 5b93df8 into main Sep 7, 2022
@pankajastro pankajastro deleted the dtt_get_value_list branch September 7, 2022 05:27
@tatiana tatiana mentioned this pull request Sep 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tatiana tatiana tatiana left review comments

@kaxil kaxil kaxil left review comments

@utkarsharma2 utkarsharma2 utkarsharma2 approved these changes

@dimberman dimberman Awaiting requested review from dimberman dimberman is a code owner

@pankajkoti pankajkoti Awaiting requested review from pankajkoti

@sunank200 sunank200 Awaiting requested review from sunank200 sunank200 is a code owner

@feluelle feluelle Awaiting requested review from feluelle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement get_value_list (Dynamic Task Templates)
6 participants
@pankajastro @tatiana @sunank200 @kaxil @utkarsharma2 @feluelle