Add section explaining table metadata #774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utkarsharma2
requested review from
dimberman,
tatiana,
sunank200,
pankajastro,
pankajkoti and
feluelle
as code owners
Codecov Report
@@ Coverage Diff @@
## main #774 +/- ##
==========================================
- Coverage 93.39% 93.20% -0.20%
==========================================
Files 43 43
Lines 1846 1853 +7
Branches 230 232 +2
==========================================
+ Hits 1724 1727 +3
- Misses 96 98 +2
- Partials 26 28 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
tatiana
reviewed
Sep 5, 2022
There was a problem hiding this comment.
@utkarsharma2 it is probably worth explaining where we retrieve the metadata information from when the user doesn't set this property!
Co-authored-by: Tatiana Al-Chueyr <tatiana.alchueyr@gmail.com>
Co-authored-by: Tatiana Al-Chueyr <tatiana.alchueyr@gmail.com>
phanikumv
reviewed
Sep 5, 2022
python-sdk/example_dags/example_amazon_s3_snowflake_transform.py
Outdated
Show resolved
Hide resolved
python-sdk/example_dags/example_amazon_s3_snowflake_transform.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Phani Kumar <94376113+phanikumv@users.noreply.github.com>
Co-authored-by: Phani Kumar <94376113+phanikumv@users.noreply.github.com>
Co-authored-by: Phani Kumar <94376113+phanikumv@users.noreply.github.com>
Co-authored-by: Phani Kumar <94376113+phanikumv@users.noreply.github.com>
kaxil
reviewed
Sep 6, 2022
Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com>
feluelle
approved these changes
Sep 6, 2022
kaxil
approved these changes
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is the current behavior?
Some of the examples are in https://astro-sdk-python.readthedocs.io/en/stable/astro/sql/operators/load_file.htm. use the metadata parameter when creating a Table, but AFAICT we don't explain what that does.
closes: #767
What is the new behavior?
Added section in docs explaining the usage of Metadata.
Does this introduce a breaking change?
No
Checklist