Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish Redshift benchmark results #806

Merged
merged 3 commits into from Sep 14, 2022
Merged

Conversation

pankajkoti
Copy link
Contributor

@pankajkoti pankajkoti commented Sep 8, 2022

Publish Redshift benchmark results for native and default approach.

The existing dataset failed with schema mismatch error while inserting rows.
The pandas auto-detection created schema with columns as varchar(256) limiting
the values to be 256 bytes long. However, some row contained a value larger than 256
bytes and then it complained with value too long error.
Hence, we have created new fake data set and kept in S3 with data
of required various sizes for benchmarking purposes and have also updated
the datasets.md to provide details of this new files.

blocked by: #805
closes: #748

@codecov
Copy link

codecov bot commented Sep 8, 2022

Codecov Report

Base: 93.25% // Head: 93.30% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (52ff732) compared to base (8b79c39).
Patch has no changes to coverable lines.

❗ Current head 52ff732 differs from pull request most recent head 9b6c74f. Consider uploading reports for the commit 9b6c74f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #806      +/-   ##
==========================================
+ Coverage   93.25%   93.30%   +0.04%     
==========================================
  Files          47       44       -3     
  Lines        2046     1911     -135     
  Branches      256      237      -19     
==========================================
- Hits         1908     1783     -125     
+ Misses        107      100       -7     
+ Partials       31       28       -3     
Impacted Files Coverage Δ
python-sdk/src/astro/airflow/datasets.py 83.33% <0.00%> (-11.12%) ⬇️
python-sdk/src/astro/sql/operators/raw_sql.py 86.36% <0.00%> (-3.30%) ⬇️
python-sdk/src/astro/sql/operators/export_file.py 93.93% <0.00%> (-0.80%) ⬇️
python-sdk/src/astro/databases/snowflake.py 95.95% <0.00%> (-0.66%) ⬇️
python-sdk/src/astro/sql/operators/transform.py 88.00% <0.00%> (-0.47%) ⬇️
python-sdk/src/astro/sql/operators/dataframe.py 93.05% <0.00%> (-0.37%) ⬇️
...thon-sdk/src/astro/sql/operators/base_decorator.py 94.05% <0.00%> (-0.29%) ⬇️
python-sdk/src/astro/databases/base.py 96.10% <0.00%> (-0.26%) ⬇️
python-sdk/src/astro/databases/aws/redshift.py 93.04% <0.00%> (-0.18%) ⬇️
python-sdk/src/astro/sql/operators/load_file.py 97.14% <0.00%> (-0.08%) ⬇️
... and 26 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dimberman
Copy link
Collaborator

dimberman commented Sep 8, 2022

@pankajkoti why did we have to use a fake dataset for redshift? Can you please add this to the description?

@pankajkoti
Copy link
Contributor Author

@pankajkoti why did we have to use a fake dataset for redshift? Can you please add this to the description?

@dimberman Updated the description. Please check

@utkarsharma2
Copy link
Collaborator

utkarsharma2 commented Sep 8, 2022

@pankajkoti Let's not merge this PR until we resolve and merge - #805

@pankajkoti pankajkoti marked this pull request as draft September 8, 2022 22:36
@utkarsharma2 utkarsharma2 marked this pull request as ready for review September 14, 2022 18:13
@utkarsharma2 utkarsharma2 merged commit f91a84a into main Sep 14, 2022
@utkarsharma2 utkarsharma2 deleted the redshift-benchmark-results branch September 14, 2022 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Benchmarking data for REDSHIFT
5 participants