Fix sql injection issues #807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add related tests
dimberman
reviewed
Sep 8, 2022
| if self.table_exists(source_table): | ||
| return pd.read_sql( | ||
| # We are avoiding SQL injection by confirming the table exists before this statement | ||
| f"SELECT * FROM {table_qualified_name}", # skipcq BAN-B608 |
There was a problem hiding this comment.
Thank you for catching this.
Codecov Report
@@ Coverage Diff @@
## main #807 +/- ##
==========================================
- Coverage 93.27% 93.09% -0.18%
==========================================
Files 46 46
Lines 1962 1971 +9
Branches 247 250 +3
==========================================
+ Hits 1830 1835 +5
- Misses 103 105 +2
- Partials 29 31 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
kaxil
approved these changes
Sep 9, 2022
feluelle
force-pushed
the
fix/sql-injection-issues
branch
from
9731c9f
to
ce33d74
Compare
feluelle
commented
Sep 12, 2022
feluelle
requested review from
tatiana,
utkarsharma2,
sunank200,
pankajastro and
pankajkoti
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is the current behavior?
Currently, we have some sql injection issues in our code which DeepSource detects for us, but some of them we ignored.
What is the new behavior?
This PR should fix them.
Does this introduce a breaking change?
No.
Checklist