Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs]: Update outdated Data-Aware Scheduling docs #1032

Closed
1 task
pankajastro opened this issue Jun 7, 2024 · 0 comments · Fixed by #1034
Closed
1 task

[Docs]: Update outdated Data-Aware Scheduling docs #1032

pankajastro opened this issue Jun 7, 2024 · 0 comments · Fixed by #1034
Labels
area:docs Relating to documentation, changes, fixes, improvement triage-needed Items need to be reviewed / assigned to milestone
Milestone

Comments

@pankajastro
Copy link
Contributor

Astronomer Cosmos Version

main (development)

If "Other Astronomer Cosmos version" selected, which one?

No response

dbt-core version

1.8.0

Versions of dbt adapters

No response

LoadMode

AUTOMATIC

ExecutionMode

AWS_EKS

InvocationMode

None

airflow version

2.9.0

Operating System

Linux

If a you think it's an UI issue, what browsers are you seeing the problem on?

No response

Deployment

Official Apache Airflow Helm Chart

Deployment details

No response

What happened?

The data-aware-scheduling docs look likes outdated

https://astronomer.github.io/astronomer-cosmos/configuration/scheduling.html#data-aware-scheduling

See: https://apache-airflow.slack.com/archives/C059CC42E9W/p1717713106253499

Relevant log output

No response

How to reproduce

NA

Anything else :)?

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Contact Details

No response

@pankajastro pankajastro added bug Something isn't working triage-needed Items need to be reviewed / assigned to milestone labels Jun 7, 2024
@dosubot dosubot bot added the area:docs Relating to documentation, changes, fixes, improvement label Jun 7, 2024
@tatiana tatiana changed the title [Bug]: Update outdated Data-Aware Scheduling docs [Docs]: Update outdated Data-Aware Scheduling docs Jun 7, 2024
@tatiana tatiana removed the bug Something isn't working label Jun 7, 2024
@tatiana tatiana added this to the Cosmos 1.5.0 milestone Jun 7, 2024
tatiana added a commit that referenced this issue Jun 7, 2024
[The
documentation](https://astronomer.github.io/astronomer-cosmos/configuration/scheduling.html)
was outdated.

The method `get_dbt_dataset` no longer exists. It used to exist in older
versions of Cosmos (before 1.1) when the URIs respected the format:

`Dataset(f"DBT://{connection_id.upper()}/{project_name.upper()}/{model_name.upper()}")`

More information on why we changed this:
#305

Closes: #1032
pankajkoti pushed a commit that referenced this issue Jun 7, 2024
[The
documentation](https://astronomer.github.io/astronomer-cosmos/configuration/scheduling.html)
was outdated.

The method `get_dbt_dataset` no longer exists. It used to exist in older
versions of Cosmos (before 1.1) when the URIs respected the format:

`Dataset(f"DBT://{connection_id.upper()}/{project_name.upper()}/{model_name.upper()}")`

More information on why we changed this:
#305

Closes: #1032
(cherry picked from commit c47e104)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:docs Relating to documentation, changes, fixes, improvement triage-needed Items need to be reviewed / assigned to milestone
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants