Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change operators to log dbt commands output as opposed to recording to XCom #513

Merged
merged 2 commits into from
Sep 6, 2023

Conversation

tatiana
Copy link
Collaborator

@tatiana tatiana commented Sep 6, 2023

All Cosmos operators were dumping unnecessary data to XCom.
Change the behavior to log the information as opposed to polluting XCom.

Closes: #304

@netlify
Copy link

netlify bot commented Sep 6, 2023

👷 Deploy Preview for amazing-pothos-a3bca0 processing.

Name Link
🔨 Latest commit 4c98600
🔍 Latest deploy log https://app.netlify.com/sites/amazing-pothos-a3bca0/deploys/64f89498f21ce70007734eb5

@tatiana tatiana temporarily deployed to internal September 6, 2023 11:52 — with GitHub Actions Inactive
@tatiana tatiana added this to the 1.1.0 milestone Sep 6, 2023
@tatiana tatiana changed the title Remove behaviour of outputting to XCom during execute Change operators to log dbt commands output as opposed to recording to XCom Sep 6, 2023
@tatiana tatiana marked this pull request as ready for review September 6, 2023 12:25
@tatiana tatiana requested a review from a team as a code owner September 6, 2023 12:25
@tatiana tatiana requested a review from a team September 6, 2023 12:25
@tatiana tatiana temporarily deployed to internal September 6, 2023 12:40 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Patch coverage: 60.00% and project coverage change: +0.32% 🎉

Comparison is base (6c3d673) 91.30% compared to head (4c98600) 91.63%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #513      +/-   ##
==========================================
+ Coverage   91.30%   91.63%   +0.32%     
==========================================
  Files          49       49              
  Lines        1921     1888      -33     
==========================================
- Hits         1754     1730      -24     
+ Misses        167      158       -9     
Files Changed Coverage Δ
cosmos/operators/docker.py 70.37% <37.50%> (+0.60%) ⬆️
cosmos/operators/kubernetes.py 70.52% <37.50%> (+0.52%) ⬆️
cosmos/operators/local.py 82.46% <100.00%> (+0.33%) ⬆️
cosmos/operators/virtualenv.py 97.77% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cosmos/operators/docker.py Outdated Show resolved Hide resolved
@tatiana tatiana mentioned this pull request Sep 6, 2023
@tatiana tatiana temporarily deployed to internal September 6, 2023 15:02 — with GitHub Actions Inactive
@tatiana tatiana requested a review from jlaneve September 6, 2023 15:27
@harels harels merged commit c7a203a into main Sep 6, 2023
40 of 41 checks passed
@harels harels deleted the cleanup-xcom branch September 6, 2023 15:45
tatiana added a commit that referenced this pull request Sep 6, 2023
**Features**

* Support dbt global flags (via dbt_cmd_global_flags in operator_args)
by @tatiana in #469
* Support parsing DAGs when there are no connections by @jlaneve in #489

**Enhancements**

* Hide sensitive field when using BigQuery keyfile_dict profile mapping
by @jbandoro in #471
* Consistent Airflow Dataset URIs, inlets and outlets with `Openlineage
package <https://pypi.org/project/openlineage-integration-common/>`_ by
@tatiana in #485. `Read more
<https://astronomer.github.io/astronomer-cosmos/configuration/lineage.html>`_.
* Refactor ``LoadMethod.DBT_LS`` to run from a temporary directory with
symbolic links by @tatiana in #488
* Run ``dbt deps`` when using ``LoadMethod.DBT_LS`` by @DanMawdsleyBA in
#481
* Update Cosmos log color to purple by @harels in #494
* Change operators to log ``dbt`` commands output as opposed to
recording to XCom by @tatiana in #513

**Bug fixes**

* Fix bug on select node add exclude selector subset ids logic by
@jensenity in #463
* Refactor dbt ls to run from a temporary directory, to avoid Read-only
file system errors during DAG parsing, by @tatiana in #414
* Fix profile_config arg in DbtKubernetesBaseOperator by @david-mag in
#505
* Fix SnowflakePrivateKeyPemProfileMapping private_key reference by
@nacpacheco in #501
* Fix incorrect temporary directory creation in VirtualenvOperator init
by @tatiana in #500
* Fix log propagation issue by @tatiana in #498
* Fix PostgresUserPasswordProfileMapping to retrieve port from
connection by @jlneve in #511

**Others**

* Docs: Fix RenderConfig load argument by @jbandoro in #466
* Enable CI integration tests from external forks by @tatiana in #458
* Improve CI tests runtime by @tatiana in #457
* Change CI to run coverage after tests pass by @tatiana in #461
* Fix forks code revision in code coverage by @tatiana in #472
* [pre-commit.ci] pre-commit autoupdate by @pre-commit-ci in #467
* Drop support to Python 3.7 in the CI test matrix by @harels in #490
* Add Airflow 2.7 to the CI test matrix by @tatiana in #487
* Add MyPy type checks to CI since we exceeded pre-commit disk quota
usage by @tatiana in #510
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review and refactor code to avoid polluting Xcom
3 participants