-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support static_index.html docs #999
Conversation
✅ Deploy Preview for sunny-pastelito-5ecb04 canceled.
|
@dwreeves, thanks for these improvements! |
Sorry, for a long time I had issues with pre-commit due to a strange error. So for a while I'd never had pre-commit turned on for the repo. I only recently fixed the issue and just forgot to |
86f017d
to
bb35621
Compare
bb35621
to
ce93392
Compare
I added Even though |
…os into support-static-index
ce93392
to
f40edd6
Compare
@tatiana Tests are stuck for some odd reason, but otherwise passing, so this is ready for review. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #999 +/- ##
==========================================
+ Coverage 95.75% 95.81% +0.06%
==========================================
Files 62 62
Lines 2965 3009 +44
==========================================
+ Hits 2839 2883 +44
Misses 126 126 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dwreeves I think we're super close to get this change merged, do you by any chance have bandwith to improve a bit the test coverage? Codecov gave some feedback.
We'll release this in 1.5
@tatiana When are you intending on releasing 1.5? I can try to get this done over the weekend but not until then. |
The current plan is the 24 June 2024, and we can have alphas/release candidates with the change beforehand: |
…os into support-static-index
1866af8
to
0f2ca86
Compare
0f2ca86
to
d717e5e
Compare
d717e5e
to
aa013ff
Compare
aa013ff
to
0c46d00
Compare
…stronomer-cosmos into support-static-index
0c46d00
to
1baa00f
Compare
883b67f
to
9eb3b82
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @dwreeves , it looks great!
Description
static_index.html
for dbt docs.cosmos/plugins/__init__.py
. Refactoring is designed to make them behave a little more predictably, and to make them look a little more like Airflow 2.8+'sObjectStoragePath
class. Of course, this is far, far from complete.Related Issue(s)
dbt docs generate --static
#986Breaking Change?
No breaking changes as far as the high level API is concerned.
Checklist