Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement GKEStartPodOperatorAsync #177

Closed
raphaelauv opened this issue Mar 31, 2022 · 1 comment · Fixed by #347
Closed

Implement GKEStartPodOperatorAsync #177

raphaelauv opened this issue Mar 31, 2022 · 1 comment · Fixed by #347
Assignees
Labels
area/async Deferrable/async operators feature New feature or request

Comments

@raphaelauv
Copy link
Contributor

raphaelauv commented Mar 31, 2022

GKEStartPodOperator is a useful operator that retrieve at every run the config_file of a GKE thanks to gcloud cli

so you don't need to manage the update of :

  • a K8S config_file
    or
  • a airflow connection kubernetes_conn_id

Having a GKEStartPodOperatorAsync would be great

@raphaelauv raphaelauv added the feature New feature or request label Mar 31, 2022
@raphaelauv
Copy link
Contributor Author

raphaelauv commented Mar 31, 2022

look like it would be necessary to edit the GKEStartPodOperator to move all the content of execute in a separate function load_gke_context

so we could write :

GKEStartPodOperatorAsync(KubernetesPodOperatorAsync)

    ...

    def execute(self, context: 'Context') -> Optional[str]:
        GKEStartPodOperator.load_gke_context(context)
        return super().execute(context)    

@raphaelauv raphaelauv changed the title GKEStartPodOperator async GKEStartPodOperatorAsync Mar 31, 2022
@phanikumv phanikumv added the area/async Deferrable/async operators label Apr 4, 2022
@phanikumv phanikumv changed the title GKEStartPodOperatorAsync Implement GKEStartPodOperatorAsync Apr 11, 2022
@pankajastro pankajastro linked a pull request May 17, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/async Deferrable/async operators feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants